Sync MaxGitDiffLineCharacters with conf/app.ini #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MAX_GIT_DIFF_LINE_CHARACTERS was updated in #1845 but the corresponding default value of MaxGitDiffLineCharacters was not changed. This can lead to inconsistencies.
Codecov Report
@@ Coverage Diff @@ ## master #2779 +/- ## ======================================= Coverage 27.08% 27.08% ======================================= Files 88 88 Lines 17264 17264 ======================================= Hits 4676 4676 Misses 11909 11909 Partials 679 679Continue to review full report at Codecov.
|
tboerger added the lgtm/need 2 
lafriks added the issue/regression 
| LGTM |
tboerger added lgtm/need 1 
| LGTM |
tboerger added lgtm/done 
| @michaelkuhn could you send a backport PR to branch |
lafriks pushed a commit that referenced this pull request Oct 25, 2017
vdbt pushed a commit to vdbt/gitea that referenced this pull request Oct 27, 2017
MAX_GIT_DIFF_LINE_CHARACTERS was updated in go-gitea#1845 but the corresponding default value of MaxGitDiffLineCharacters was not changed. This can lead to inconsistencies.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
MAX_GIT_DIFF_LINE_CHARACTERSwas updated in #1845 but the corresponding default value ofMaxGitDiffLineCharacterswas not changed. This can lead to inconsistencies.Specifically, with my
bindatabuild, Gitea used the default of 500 instead of 5000 becauseMAX_GIT_DIFF_LINE_CHARACTERSis not set in mycustom/conf/app.ini.I found the bug with version 1.2 but it should also apply to master.