Fix PR, milestone and label functionality if issue unit is disabled #2710
Conversation
lafriks added backport/v1.2 type/bug issue/regression 
Codecov Report
@@ Coverage Diff @@ ## master #2710 +/- ## ======================================= Coverage 26.95% 26.95% ======================================= Files 87 87 Lines 17301 17301 ======================================= Hits 4664 4664 Misses 11957 11957 Partials 680 680Continue to review full report at Codecov.
|
tboerger added the lgtm/need 2 
lafriks force-pushed the fix/pr_with_ext_issues branch from 9a03cc8 to d2237b9 Compare 
| LGTM |
tboerger added lgtm/need 1 
routers/repo/issue.go Outdated
| prUnitEnabled := ctx.Repo.Repository.UnitEnabled(models.UnitTypePullRequests) | ||
| for _, issue := range issues { | ||
| if issue.IsPull && !prUnitEnabled || !issue.IsPull && !issueUnitEnabled { | ||
| ctx.Handle(404, "UnitEnabled", nil) |
routers/repo/issue.go Outdated
| } | ||
| if issue.IsPull && !ctx.Repo.Repository.UnitEnabled(models.UnitTypePullRequests) || | ||
| !issue.IsPull && !ctx.Repo.Repository.UnitEnabled(models.UnitTypeIssues) { | ||
| ctx.Handle(404, "UnitEnabled", nil) |
There was a problem hiding this comment.
Error message should be UnitDisabled
There was a problem hiding this comment.
@daviian no, there should be function name that returned error so that from log entries it would be possible to understand what happened
There was a problem hiding this comment.
From that point of view yes, but it is confusing at the first moment.
There was a problem hiding this comment.
That is how it is used in rest of the code :)
There was a problem hiding this comment.
@lafriks However in this case the UnitEnabled doesn't even return an error and 404 happens if the required unit is not enabled.
| @daviian updated ;) |
| @lafriks Update and delete on comments in PR without issue tracker don't work either. |
| @daviian fixed |
| LGTM |
tboerger added lgtm/done | Make LG-TM work again |
…o-gitea#2710) * Fix PR, milestone and label functionality if issue unit is disabled or not assigned to user * Fix multi-actions in PR page * Change error message * Fix comment update and delete functionality in PR
5 participants
Fix PR, milestone and label functionality if issue unit is disabled or not available for user
Fixes #2447