Skip to content

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Oct 14, 2017

Fixes #2702

@lafriks lafriks added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Oct 14, 2017
@lafriks lafriks added this to the 1.3.0 milestone Oct 14, 2017
@Morlinest
Copy link
Member

LGTM

Tested on postgresql.

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 14, 2017
@codecov-io
Copy link

Codecov Report

Merging #2703 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2703 +/- ## ======================================= Coverage 27.38% 27.38% ======================================= Files 86 86 Lines 17014 17014 ======================================= Hits 4659 4659 Misses 11675 11675 Partials 680 680

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e89bb7e...ae0a948. Read the comment docs.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 14, 2017
@lafriks lafriks merged commit 8863e74 into go-gitea:master Oct 14, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

5 participants