fix panic on gogs webhook creation #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
| @daviian I think it should also be fixed on line 423 |
tboerger added the lgtm/need 2 
Codecov Report
@@ Coverage Diff @@ ## master #2675 +/- ## ======================================= Coverage 27.13% 27.13% ======================================= Files 86 86 Lines 17062 17062 ======================================= Hits 4629 4629 Misses 11755 11755 Partials 678 678Continue to review full report at Codecov.
|
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
| @lafriks Done |
| LGTM |
tboerger added lgtm/need 1 
| LGTM |
tboerger added lgtm/done 
| @daviian please send a backport PR to v1.2 |
daviian added a commit to daviian/gitea that referenced this pull request Oct 8, 2017
* fix panic on gogs webhook creation Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com> * fix panic in gogs webhook edit Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
lunny pushed a commit that referenced this pull request Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As title.
Targets #2671
Needs backport to 1.2