Refactor duplicated code in repo handlers #2657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ethantkoenig force-pushed the refactor/repo_handler branch from be7b7e9 to a79b704 Compare 
lafriks added the type/refactoring 
Codecov Report
@@ Coverage Diff @@ ## master #2657 +/- ## ======================================= Coverage 27.13% 27.13% ======================================= Files 86 86 Lines 17061 17061 ======================================= Hits 4629 4629 Misses 11754 11754 Partials 678 678Continue to review full report at Codecov.
|
tboerger added the lgtm/need 2 
| LGTM |
tboerger added lgtm/need 1 
daviian suggested changes Oct 4, 2017
modules/context/repo.go Outdated
| EarlyResponseForGoGetMeta(ctx) | ||
| return | ||
| } | ||
| ctx.Error(404, "no access right") |
There was a problem hiding this comment.
Please change to ctx.Handle(404, "no access right", nil)
daviian approved these changes Oct 4, 2017
| LGTM |
tboerger added lgtm/done 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Move duplicated code in
RepoIDAssignmentandRepoAssignmenthandlers to a helper function. Also removed an unused var and fix a typo