Use Semantic UI's Search component for user and repo search #2636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #2636 +/- ## ======================================= Coverage 27.11% 27.11% ======================================= Files 86 86 Lines 17062 17062 ======================================= Hits 4627 4627 Misses 11757 11757 Partials 678 678Continue to review full report at Codecov.
|
tboerger added the lgtm/need 2 
daviian suggested changes Oct 1, 2017
public/js/index.js Outdated
| $searchRepoBox.search({ | ||
| minCharacters: 2, | ||
| apiSettings: { | ||
| url: suburl + '/api/v1/repos/search?q={query}', |
ethantkoenig approved these changes Oct 2, 2017
public/js/index.js Outdated
| hideWhenLostFocus('#search-user-box .results', '#search-user-box'); | ||
| } | ||
| | ||
| // FIXME: merge common parts in two functions |
There was a problem hiding this comment.
nit: remove this comment now that it is stale
daviian approved these changes Oct 2, 2017
| Please remove comment as @ethantkoenig mentioned, otherwise LGTM |
tboerger added lgtm/need 1 | @ethantkoenig @daviian Done. 😃 |
| LGTM |
tboerger added lgtm/done 
| Make LG-TM work again |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Current user and repo search input is not support keyboard navigation and must use mouse click to select item.
So I use Semantic UI's Search component replace the jquery ajax code and html generating code, for improve the UI experience.
Here is the screenshots:
New user search
New repo search
Old user search (Can only use mouse select):
