Skip to content

Remove redudant issue LoadAttributes() calls #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2017
Merged

Remove redudant issue LoadAttributes() calls #2614

merged 1 commit into from
Sep 27, 2017

Conversation

Morlinest
Copy link
Member

This should reduce duplicated LoadAttributes() calls. Functions models.Issues and models.GetIssueByIndex are already doing it. This should speed up Gitea a little bit when working with issues.
@codecov-io
Copy link

Codecov Report

Merging #2614 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2614 +/- ## ========================================= - Coverage 27.32% 27.3% -0.02%  ========================================= Files 86 86 Lines 17143 17139 -4 ========================================= - Hits 4684 4680 -4  Misses 11781 11781 Partials 678 678
Impacted Files Coverage Δ
models/issue.go 24.72% <100%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339d7de...64f036e. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 27, 2017
@lafriks
Copy link
Member

lafriks commented Sep 27, 2017

LGTM
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 27, 2017
@andreynering
Copy link
Contributor

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 27, 2017
@andreynering andreynering merged commit cc84ca4 into go-gitea:master Sep 27, 2017
@Morlinest Morlinest deleted the fix/reduce-redudant-load-calls branch September 27, 2017 12:52
@lunny lunny added this to the 1.3.0 milestone Sep 28, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 28, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

6 participants

@Morlinest @codecov-io @lafriks @andreynering @lunny @tboerger