Skip to content

Fix lint errors #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2017
Merged

Fix lint errors #2547

merged 1 commit into from
Sep 19, 2017

Conversation

ethantkoenig
Copy link
Member

make lint is failing in CI. See https://drone.gitea.io/go-gitea/gitea/693/5, for example.
@codecov-io
Copy link

Codecov Report

Merging #2547 into master will increase coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2547 +/- ## ========================================== + Coverage 26.96% 26.98% +0.02%  ========================================== Files 84 84 Lines 16906 16892 -14 ========================================== Hits 4559 4559 + Misses 11672 11660 -12  + Partials 675 673 -2
Impacted Files Coverage Δ
models/gpg_key.go 30.18% <0%> (+0.28%) ⬆️
models/login_source.go 0% <0%> (ø) ⬆️
models/issue.go 25.02% <0%> (+0.07%) ⬆️
models/org.go 69.8% <100%> (+0.44%) ⬆️
models/ssh_key.go 10.39% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d155d0e...de60e75. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 19, 2017
@lunny lunny added this to the 1.3.0 milestone Sep 19, 2017
@lunny
Copy link
Member

lunny commented Sep 19, 2017

LGTM
@lunny
Copy link
Member

lunny commented Sep 19, 2017

make L-G-T-M work
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 19, 2017
@lunny lunny mentioned this pull request Sep 19, 2017
Merged
@jonasfranz
Copy link
Member

Could you add a backport to v1.2 too, since the CI test is failong too?
@lafriks
Copy link
Member

lafriks commented Sep 19, 2017

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 19, 2017
@lafriks lafriks merged commit 4cb9394 into go-gitea:master Sep 19, 2017
@ethantkoenig ethantkoenig deleted the fix/lint branch September 19, 2017 15:08
@jonasfranz
Copy link
Member

@ethantkoenig Could you add a backport to v1.2 too, since the CI test is failong too?
@ethantkoenig ethantkoenig mentioned this pull request Sep 20, 2017
Merged
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request Sep 20, 2017
@ethantkoenig @lafriks
Fix lint errors (go-gitea#2547)
6131912
@lunny lunny added backport/done All backports for this PR have been created backport/v1.2 and removed backport/v1.2 labels Sep 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting

6 participants

@ethantkoenig @codecov-io @lunny @jonasfranz @lafriks @tboerger