Make basic functionality work without JavaScript #2541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
appleboy approved these changes Sep 18, 2017
| LGTM |
tboerger added the lgtm/need 1 
| LGTM |
3 tasks
| make L-G-T-M work |
tboerger added lgtm/done 
Codecov Report
@@ Coverage Diff @@ ## master #2541 +/- ## ======================================= Coverage 26.96% 26.96% ======================================= Files 84 84 Lines 16906 16906 ======================================= Hits 4559 4559 Misses 11672 11672 Partials 675 675Continue to review full report at Codecov.
|
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Targeting #2538 to make the basic functionality of the website work better when JavaScript is disabled. The dropdowns of branches still don't work without JavaScript (the dropdown works, but the names of the branches don't appear), but this pull request makes the other dropdowns work just fine by using CSS and the
<noscript>tag (unless I'm missing something).