Fix unit test race condition #2516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ethantkoenig force-pushed the fix/test_race_cond branch from de98001 to f4718cd Compare 
ethantkoenig force-pushed the fix/test_race_cond branch from f4718cd to 53d16da Compare 
| LGTM |
tboerger added the lgtm/need 2 
Codecov Report
@@ Coverage Diff @@ ## master #2516 +/- ## ====================================== Coverage 27.7% 27.7% ====================================== Files 83 83 Lines 16914 16914 ====================================== Hits 4686 4686 Misses 11553 11553 Partials 675 675Continue to review full report at Codecov.
|
tboerger added lgtm/need 1 
| LGTM |
tboerger added lgtm/done 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Test would previously fail if the id had not added to
pullRequestQueuewithin 1 millisecond; it now waits until something is added to the queue (with a 1 second timeout).See https://drone.gitea.io/go-gitea/gitea/606/6 for an example of the test failing.