Skip to content

Conversation

daviian
Copy link
Member

@daviian daviian commented Sep 13, 2017

As title. Targets #2502

Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
@Morlinest
Copy link
Member

Can confirm, it fixes #2502. Tested on commit detail page and PR commit page.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 13, 2017
@codecov-io
Copy link

Codecov Report

Merging #2503 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2503 +/- ## ======================================= Coverage 27.85% 27.85% ======================================= Files 83 83 Lines 16825 16825 ======================================= Hits 4686 4686 Misses 11464 11464 Partials 675 675

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633de01...c121332. Read the comment docs.

@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Sep 14, 2017
@lafriks lafriks added this to the 1.3.0 milestone Sep 14, 2017
@lafriks
Copy link
Member

lafriks commented Sep 14, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 14, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Sep 14, 2017

Got a screenshot?

@appleboy
Copy link
Member

maybe provide before and after screenshot.

@lafriks
Copy link
Member

lafriks commented Sep 14, 2017

@bkcsoft @appleboy

Before:
image

After:
image

@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2017
@bkcsoft bkcsoft merged commit a89692d into go-gitea:master Sep 14, 2017
@lunny lunny mentioned this pull request Sep 14, 2017
1 task
@daviian daviian deleted the bugfix/ui-rendering-commit-detail branch September 14, 2017 07:03
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

7 participants