Skip to content

Hotfix: Add time manually adds time in nanoseconds #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2017
Merged

Hotfix: Add time manually adds time in nanoseconds #2499

merged 2 commits into from
Sep 13, 2017

Conversation

jonasfranz
Copy link
Member

The add time manually form adds the time as nanoseconds but it should be seconds.
This issue is reported by @gsantner (#2211 (comment)).

For more information please have a look at @gsantner comment: #2211 (comment)
@jonasfranz
Hotfix for "Add time manually" (go-gitea#2211 (comment))
09f817c 
Signed-off-by: Jonas Franz <info@jonasfranz.software>
@jonasfranz jonasfranz mentioned this pull request Sep 13, 2017
Closed
@lafriks
Copy link
Member

lafriks commented Sep 13, 2017

LGTM
@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 13, 2017
@lafriks lafriks added this to the 1.3.0 milestone Sep 13, 2017
@lafriks lafriks added the issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP label Sep 13, 2017
@codecov-io
Copy link

Codecov Report

Merging #2499 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2499 +/- ## ======================================= Coverage 27.85% 27.85% ======================================= Files 83 83 Lines 16825 16825 ======================================= Hits 4686 4686 Misses 11464 11464 Partials 675 675

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b473d...b3fd467. Read the comment docs.
@bkcsoft
Copy link
Member

bkcsoft commented Sep 13, 2017

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 13, 2017
@tboerger
Copy link
Member

Wrong report from drone, was successful so I'm merging it https://drone.gitea.io/go-gitea/gitea/573
@tboerger tboerger merged commit 633de01 into go-gitea:master Sep 13, 2017
@jonasfranz jonasfranz deleted the hotfix-add-time branch September 13, 2017 19:02
@jonasfranz jonasfranz changed the title Hotifx: Add time manually adds time in nanoseconds Hotfix: Add time manually adds time in nanoseconds Sep 19, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

6 participants

@jonasfranz @lafriks @codecov-io @bkcsoft @tboerger @tonivj5