Allow changing integration test database connection using env variables #2484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lafriks added the topic/build 
| Unrelated build-failure LGTM |
tboerger added the lgtm/need 1 
| LGTM |
tboerger added lgtm/done lafriks force-pushed the feat/allow_configurable_test_conn branch from c15bb99 to 105140b Compare 
| Rebased upstream/master (and make LG-TM work again) |
| @lafriks need rebase |
lafriks force-pushed the feat/allow_configurable_test_conn branch from 105140b to 0786071 Compare | @lunny rebased & fixed conflicts |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Allows to run integration tests without docker and with custom connection parameters, example
TEST_PGSQL_HOST=localhost:5432 make test-pgsqlorTEST_MYSQL_HOST=localhost:3306 make test-mysql