Make repo private to not interfere with other tests #2467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sapk changed the title sapk changed the title 
| trusted LGTM |
tboerger added the lgtm/need 1 
| LGTM |
tboerger added lgtm/done 
| Even if PR CI and local tests passed, It seems that it make master failed on gpg test ... |
| I have tested master(95c408f), tests is work. |
| @lunny It's seems that tests are randomly failing : https://drone.gitea.io/go-gitea/gitea/455 😢 so maybe not related. |
1 task
sapk added a commit to sapk-fork/gitea that referenced this pull request Oct 26, 2017
lunny pushed a commit that referenced this pull request Oct 27, 2017
* Only check at least one email gpg key (#2266) * Only require one email (possibly not yet validated) * Update message error and check validation of commit * Add integrations tests * Complete integration for import * Add pre-check/optimization * Add some test (not finished) * Finish * Fix fixtures * Fix typo * Don't guess key ID * Make repo private to no interfere with other tests (#2467) * GPG key email verification no longer case sensitive (#2661) (#2663) * GPG key email verification no longer case sensitive (#2661) * case insensitive GPG key email verification now cached (#2661) Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since dev of #2266 some tests were added. Change made in PR #2266 add a repo fixture that interfere with thoses tests.
To fix that, I made the repo fixture private.