Update hard-coded version to 1.3.0+dev #2390
Conversation
strk changed the title | Sorry this is for 1.3.0+dev (force-pushed). |
tboerger added the lgtm/need 2 
| How about 1.3.0-dev since it's target is 1.3.0 but isn't reach. |
| I'm still confused about + vs - Before the change we used + What's the difference, semantically ? Will 1.3.0-dev be older than 1.3.0 ? Will 1.3.0+dev be newer than 1.3.0 ? |
integrations/version_test.go Outdated
There was a problem hiding this comment.
You forgot to update this like the main.go in the last commit
| I realized that the test doens't need to match the hard-coded version. I'm actually tempted to use "test" in there instead, to avoid the confusion (and I guess that test could test at least two versions...) |
| It seems when we build via |
| That's because the Makefile rule generates version via `git describe`, which does not read the hard-coded version number in source code. If you want a better description there, you can add a 1.3 tag pointing to the first commit which got into master branch, ie: git tag 1.3 a915a09 |
| So what's the meaning of the hard-code? |
| It's for when you `go get` or `go build`, or build from sources (outside of a git repository). This PR does not change policy, just fixes its current application |
| LGTM |
tboerger added lgtm/need 1 | @lunny so is this good to merge now ? |
| Shouldn't be version set only when you add tag? Now it should be Edit: Changed |
| For master, I suggest always use |
| LGTM |
tboerger added lgtm/done 
Codecov Report
@@ Coverage Diff @@ ## master #2390 +/- ## ======================================= Coverage 27.38% 27.38% ======================================= Files 86 86 Lines 17010 17010 ======================================= Hits 4658 4658 Misses 11673 11673 Partials 679 679Continue to review full report at Codecov.
|
9 participants
Was previously set to 1.1.0+dev