Skip to content

Fix releases to be counted from database not tags #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2017
Merged

Fix releases to be counted from database not tags #2389

merged 1 commit into from
Aug 28, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Aug 25, 2017

First step to fix #2154
@lafriks lafriks added this to the 1.2.0 milestone Aug 25, 2017
@sapk
Copy link
Member

sapk commented Aug 25, 2017

LGTM
@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 25, 2017
@lunny
Copy link
Member

lunny commented Aug 25, 2017

CI failed.
@sapk
Copy link
Member

sapk commented Aug 25, 2017

@lunny I am not sure that this is related to this PR maybe a bug when copying the integration env.
@lafriks can you please restart the build via commit --amend or rebase ?
@lafriks lafriks force-pushed the correct_release_count branch from 485582d to 1448ba4 Compare August 28, 2017 08:01
@lafriks lafriks force-pushed the correct_release_count branch from 1448ba4 to 14cf0d1 Compare August 28, 2017 08:04
@lafriks
Copy link
Member Author

lafriks commented Aug 28, 2017

@lunny @sapk done
@lunny
Copy link
Member

lunny commented Aug 28, 2017

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 28, 2017
@lunny lunny merged commit edb95fa into go-gitea:master Aug 28, 2017
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Aug 29, 2017
@lafriks
Fix releases to be counted from database not tags (go-gitea#2389)
4ad1617
@lafriks lafriks mentioned this pull request Aug 29, 2017
Merged
lunny pushed a commit that referenced this pull request Aug 30, 2017
@lafriks @lunny
Fix releases to be counted from database not tags (#2389) (#2424)
0c910af
@lafriks lafriks added the backport/done All backports for this PR have been created label Sep 5, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

4 participants

@lafriks @sapk @lunny @tboerger