Use custom search for each filter type in dashboard #2343
Conversation
Morlinest force-pushed the feature-dashboard-filters-custom-search branch from 4278a1b to aa6a2c9 Compare 
lafriks added type/bug type/enhancement 
models/repo_list.go Outdated
There was a problem hiding this comment.
Could you please run make generate-swagger to regenerate the swagger spec? This might resolve the conflict. If not please resolve the conflicts manually.
There was a problem hiding this comment.
I did. Conflicts are new due to new master. I'll rebase and run it again.
models/repo_list.go Outdated
There was a problem hiding this comment.
Please add swagger:parameter like here: https://github.com/Morlinest/gitea/blob/aa6a2c996252707a1ada79c52661e1f464bccee9/models/repo_list.go#L92
public/swagger.v1.json Outdated
There was a problem hiding this comment.
Do not add swagger stuff manually because it will be overwritten if you run make generate-swagger.
There was a problem hiding this comment.
Never touched this file manually. It was generated by make generate-swagger (exactly mingw32-make generate-swagger).
Morlinest force-pushed the feature-dashboard-filters-custom-search branch 2 times, most recently from 2f0a8a2 to 2b16b01 Compare 
tboerger added the lgtm/need 2 Morlinest force-pushed the feature-dashboard-filters-custom-search branch 2 times, most recently from f1289e2 to 8cf8380 Compare Morlinest changed the title Morlinest force-pushed the feature-dashboard-filters-custom-search branch from 8cf8380 to 9a7a5a0 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #2343 +/- ## ======================================= Coverage 26.84% 26.84% ======================================= Files 89 89 Lines 17608 17608 ======================================= Hits 4727 4727 Misses 12195 12195 Partials 686 686Continue to review full report at Codecov.
|
Morlinest force-pushed the feature-dashboard-filters-custom-search branch 3 times, most recently from c520dfc to 62655d8 Compare 
Morlinest force-pushed the feature-dashboard-filters-custom-search branch 2 times, most recently from d96fd6a to dd7b4e5 Compare | PR reopened as all needed features were merged. Rebased on master, ready for testing, review and comments. |
| @JonasFranzDEV please review again |
Morlinest force-pushed the feature-dashboard-filters-custom-search branch from c2d1538 to 86a07f8 Compare | @lafriks FYI he was actually reviewing another PR code (as this PR was not based on master). That code is not part of this PR anymore. |
| Changed UI by removing second loader that was causing "flickering" effect if search was fast. Now the repository counter is reset on each filter change. Adding new screenshots (limit set to 5 repositories for this tests). Edit: Screenshots moved to PR description. |
| LGTM |
tboerger added lgtm/need 1 | LGTM |
tboerger added lgtm/done 
| Make LG-TM work |
| @JonasFranzDEV I hope you had no requested changes anymore. Just after merging noticed that you have not approved yet |
6 participants
Based on #2326 (need to be merged first)
Discussion on #2312
Fast network (no restrictions):
Slow network ("Slow 3G" through Chrome network setting):
Edit: Updated screnshots/gifs.