Use path not filepath in template filenames #21993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Paths in git are always separated by `/` not `\\` - therefore we should `path` and not `filepath` Fix go-gitea#21987 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added type/bug outdated/backport/v1.18 
lunny approved these changes Dec 1, 2022
GiteaBot added the lgtm/need 1 
KN4CK3R approved these changes Dec 1, 2022
GiteaBot added lgtm/done 
lunny added the reviewed/wait-merge 
lafriks approved these changes Dec 1, 2022
delvh approved these changes Dec 1, 2022
lunny removed the reviewed/wait-merge zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 3, 2022
* giteaofficial/main: docs: add `Edit this page` (go-gitea#21981) refactor some functions to support ctx as first parameter (go-gitea#21878) Remove deprecated packages & staticcheck fixes (go-gitea#22012) Add pnpm to packages/overview (go-gitea#22008) Update to Alpine 3.17 (go-gitea#21904) Update gitea-vet to check FSFE REUSE (go-gitea#22004) Multiple improvements for comment edit diff (go-gitea#21990) Remove session in api tests (go-gitea#21984) Remove duplicate "Actions" label in mobile view (go-gitea#21974) Fix generate index failure possibility on postgres (go-gitea#21998) Use path not filepath in template filenames (go-gitea#21993) Update chroma to v2.4.0 (go-gitea#22000) Util type to parse ref name (go-gitea#21969) Skip initing LFS storage if disabled (go-gitea#21996) Fix parallel creating commit status bug with tests (go-gitea#21911) Skip initing disabled storages (go-gitea#21985) Fix leaving organization bug on user settings -> orgs (go-gitea#21983) Fix typos (go-gitea#21979) Normalize `AppURL` according to RFC 3986 (go-gitea#21950)
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 3, 2022
Backport go-gitea#21993 Paths in git are always separated by `/` not `\` - therefore we should `path` and not `filepath` Fix go-gitea#21987 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lauris BH <lauris@nix.lv>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Paths in git are always separated by
/not\- therefore we shouldpathand notfilepathFix #21987
Signed-off-by: Andrew Thornton art27@cantab.net