Skip to content

Handle empty author names #21902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 23, 2022
Merged

Handle empty author names #21902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6792a71
Handle empty author names
zeripath Nov 22, 2022
95cdd59
Apply suggestions from code review
zeripath Nov 22, 2022
b83be02
Merge branch 'main' into fix-21900-handle-empty-author
lafriks Nov 22, 2022
38a8a6e
Apply suggestions from code review
lunny Nov 23, 2022
4d6dfbd
Merge branch 'main' into fix-21900-handle-empty-author
lunny Nov 23, 2022
3e88ad1
Fix import
lunny Nov 23, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@lunny
lunny authored Nov 23, 2022
commit 38a8a6edbfba8ff0f503f18b70a00fa3f0ba28c5
2 changes: 1 addition & 1 deletion modules/git/signature_gogit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func newSignatureFromCommitline(line []byte) (_ *Signature, err error) {
sig := new(Signature)
emailStart := bytes.IndexByte(line, '<')
if emailStart > 0 { // Empty name has already occurred, even if it shouldn't
sig.Name = string(line[:emailStart-1])
sig.Name = strings.TrimSpace(string(line[:emailStart-1]))
}
emailEnd := bytes.IndexByte(line, '>')
sig.Email = string(line[emailStart+1 : emailEnd])
Expand Down
2 changes: 1 addition & 1 deletion modules/git/signature_nogogit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func newSignatureFromCommitline(line []byte) (sig *Signature, err error) {
}

if emailStart > 0 { // Empty name has already occurred, even if it shouldn't
sig.Name = string(line[:emailStart-1])
sig.Name = strings.TrimSpace(string(line[:emailStart-1]))
}
sig.Email = string(line[emailStart+1 : emailEnd])

Expand Down