Fix "build from source" document to clarify the bindata tag is required. #21853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wxiaoguang force-pushed the fix-build-doc branch from f89146e to 03b6f67 Compare 
This comment was marked as off-topic.
This comment was marked as off-topic.
GiteaBot added the lgtm/need 2 
techknowlogick approved these changes Nov 18, 2022
GiteaBot added lgtm/need 1 
lunny approved these changes Nov 18, 2022
GiteaBot added lgtm/done 
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 21, 2022
* giteaofficial/main: Improve documentation for PAM and static deployment (go-gitea#21866) Add package registry cleanup rules (go-gitea#21658) Support comma-delimited string as labels in issue template (go-gitea#21831) Fix wechatwork webhook sends empty content in PR review (go-gitea#21762) Show syntax lexer name in file view/blame (go-gitea#21814) Add `context.Context` to more methods (go-gitea#21546) Timeline and color tweaks (go-gitea#21799) Fix webpack license warning (go-gitea#21815) chore: add webpack export type check (go-gitea#21857) Prevent dangling user redirects (go-gitea#21856) Fix "build from source" document to clarify the `bindata` tag is required. (go-gitea#21853) Bump loader-utils from 2.0.3 to 2.0.4 (go-gitea#21852) Do not allow Ghost access to limited visible user/org (go-gitea#21849) Fix setting HTTP headers after write (go-gitea#21833)
fsologureng pushed a commit to fsologureng/gitea that referenced this pull request Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related: #21845
I have seen many users not using
bindataand asking "why my Gitea build doesn't work".For almost 100% users, the
bindatatag is required for the production build, thebindatacontains not only the JS/CSS files, but also other essential backend data like templates.Without
bindata, Gitea is unlikely to run correctly in a production deployment.If some advanced users want to fine tune the build, they should look into source code and other documents to separate bindata files carefully and manually.