Skip to content

feat(pr review): add more space on mobile #21326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2022
Merged

feat(pr review): add more space on mobile #21326

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5838b43
feat(pr review): add more space on mobile
kolaente Oct 3, 2022
42c7704
chore: add comment for !important
kolaente Oct 11, 2022
5ff4d0b
Merge branch 'main' into feat/more-review-space-on-mobile
techknowlogick Oct 11, 2022
3fad44c
Merge branch 'main' into feat/more-review-space-on-mobile
lafriks Oct 11, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions web_src/less/_repository.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,12 @@
.comment-form-reply .footer {
padding-bottom: 1em;
}

@media @mediaSm {
.ui.segments {
margin-left: -2rem;
}
}
}

.ui.comments {
Expand Down Expand Up @@ -1165,6 +1171,10 @@
box-shadow: none;
}
}

@media @mediaSm {
padding: 1rem 0 !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why important?
Because other (fomantic?) style classes interfere otherwise?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like a comment here.
As someone (I don't know anymore who) said, it's probably a good idea to force comments explaining !importants, simply so that at some point it can be easily determined if they are still needed.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, added!
}
}

.ui.depending {
Expand Down