Skip to content

Modify milestone search keywords to be case insensitive again #20513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 28, 2022
Merged

Modify milestone search keywords to be case insensitive again #20513

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aee3b4e
Modify for #18437
tyroneyeh Jul 28, 2022
7861bc3
Merge branch 'master' into 20266-non-ascii-search
6543 Jul 28, 2022
dcc98d7
refactor
6543 Jul 28, 2022
008a68e
Update models/db/common.go
6543 Jul 28, 2022
062fdc1
rename
6543 Jul 28, 2022
f1a56cc
fix lint
6543 Jul 28, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion models/issues/milestone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"code.gitea.io/gitea/modules/setting"
api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/modules/timeutil"
"code.gitea.io/gitea/modules/util"

"xorm.io/builder"
)
Expand Down Expand Up @@ -361,7 +362,11 @@ func (opts GetMilestonesOption) toCond() builder.Cond {
}

if len(opts.Name) != 0 {
cond = cond.And(builder.Like{"UPPER(name)", strings.ToUpper(opts.Name)})
if setting.Database.UseSQLite3 {
cond = cond.And(builder.Like{"UPPER(name)", util.ToUpperASCII(opts.Name)})
} else {
cond = cond.And(builder.Like{"UPPER(name)", strings.ToUpper(opts.Name)})
}
}

return cond
Expand Down