Skip to content

Conversation

silverwind
Copy link
Member

Should be pretty stable now.

Should be pretty stable now.
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 12, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 12, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 13, 2022
@6543 6543 added this to the 1.18.0 milestone Jul 13, 2022
@techknowlogick techknowlogick merged commit 9cd1f38 into go-gitea:main Jul 13, 2022
@silverwind silverwind deleted the node18 branch July 13, 2022 16:19
@silverwind
Copy link
Member Author

silverwind commented Jul 13, 2022

CI brought up a failure related to glibc. Node 18 requires glibc 2.28 or newer but techknowlogick/xgo:go-1.18.x still runs on Ubuntu 18.04 which has glibc 2.27.

@techknowlogick are you able to upgrade the base image of techknowlogick/xgo:go-1.18.x to Ubuntu 20.04 or greater? Otherwise, we have to downgrade node to 16 for steps that run on that image.

@silverwind
Copy link
Member Author

#20356 for temporary fix.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 14, 2022
* giteaofficial/main: Fix icon margin in user/settings/repos (go-gitea#20281) Fix org label open count, including close count issue (go-gitea#20353) [skip ci] Updated translations via Crowdin Prevent context deadline error propagation in GetCommitsInfo (go-gitea#20346) Add missing return for when topic isn't found (go-gitea#20351) Upgrade to Node 18 on CI (go-gitea#20340) Fix checks in PR for empty commits go-gitea#19603 (go-gitea#20290) Use default values when provided values are empty (go-gitea#20318) Add tests for the host checking logic, clarify the behaviors (go-gitea#20328) Changelog for 1.16.9 (update) (go-gitea#20341) (go-gitea#20343) Fix various typos (go-gitea#20338) Correctly handle draft releases without a tag (go-gitea#20314) Add write check for creating Commit status (go-gitea#20332) Remove blue text on migrate page (go-gitea#20273) Updated dead link to Madeleine.js source (go-gitea#20322)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
* Upgrade to Node 18 on CI Should be pretty stable now. * restart ci Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

6 participants