Display full name (#20171) #20246
Merged
Display full name (#20171) #20246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Backport go-gitea#20171 The setting `DEFAULT_SHOW_FULL_NAME` promises to use the user's full name everywhere it can be used. Unfortunately the function `*user_model.User.ShortName()` currently uses the `.Name` instead - but this should also use the `.FullName()`. Therefore we should make `*user_model.User.ShortName()` base its pre-shortened name on the `.FullName()` function.
lunny approved these changes Jul 5, 2022
GiteaBot added the lgtm/need 1 
wxiaoguang approved these changes Jul 5, 2022
GiteaBot added lgtm/done 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backport #20171
The setting
DEFAULT_SHOW_FULL_NAMEpromises to use the user's full name everywhere it can be used.Unfortunately the function
*user_model.User.ShortName()currently uses the.Nameinstead - but this should also use the.FullName().Therefore we should make
*user_model.User.ShortName()base its pre-shortened name on the.FullName()function.