Skip to content

Webhook for Wiki changes #20219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 4, 2022
Merged

Webhook for Wiki changes #20219

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
24b5d39
Implement the wiki webhook setting (frontend, API)
f0086 Jul 2, 2022
0d38956
Notifications for wiki page changes
f0086 Jul 2, 2022
273c108
Fix distinction between new and edit wiki pages
f0086 Jul 2, 2022
0e7a91e
PayloadConvertor implementations for wiki webhook
f0086 Jul 2, 2022
e0972d4
Clarify some code comments and remove an unused locale
f0086 Jul 2, 2022
44da97c
Merge branch 'main' into 16457_wiki_webhook
f0086 Jul 8, 2022
41d9e50
Merge branch 'main' into 16457_wiki_webhook
f0086 Jul 20, 2022
81bc745
Merge branch 'main' into 16457_wiki_webhook
f0086 Jul 25, 2022
ed47745
Merge branch 'main' into 16457_wiki_webhook
f0086 Aug 2, 2022
def6afe
Merge branch 'main' into 16457_wiki_webhook
f0086 Aug 17, 2022
0442361
Merge branch 'main' into 16457_wiki_webhook
f0086 Aug 30, 2022
50dec4e
Merge branch 'main' into 16457_wiki_webhook
f0086 Sep 4, 2022
02c9616
Merge branch 'main' into 16457_wiki_webhook
zeripath Sep 4, 2022
88f3acb
Merge branch 'main' into 16457_wiki_webhook
zeripath Sep 4, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into 16457_wiki_webhook
  • Loading branch information
@f0086
f0086 authored Aug 30, 2022
commit 0442361b6871fd1fe02e797f967fce8721d3431d
6 changes: 3 additions & 3 deletions modules/notification/base/notifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ type Notifier interface {
NotifyNewWikiPage(doer *user_model.User, repo *repo_model.Repository, page, comment string)
NotifyEditWikiPage(doer *user_model.User, repo *repo_model.Repository, page, comment string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update is a better word than Edit here imo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thought about that when naming it. There is an "UpdateRelease" and an "UpdateComment", so It would be consistent with that. But this is the only place where I find the word "Update", there are other "synonyms" in use like "Change", which makes semantically more sense in that cases. So I don't "break the rule" in naming the notifier for editing a wiki page EditWikiPage to keep it semantically consistent. Take a look at all the notifiers (here). The names follow semantic names instead of consistent "CRUD"-like names. If EditWikiPage should be renamed to UpdateWikiPage, I also need to rename NewWikiPage to CreateWikiPage to bring it in line with some other actions. What do you think @lunny?
NotifyDeleteWikiPage(doer *user_model.User, repo *repo_model.Repository, page string)
NotifyNewRelease(rel *models.Release)
NotifyUpdateRelease(doer *user_model.User, rel *models.Release)
NotifyDeleteRelease(doer *user_model.User, rel *models.Release)
NotifyNewRelease(rel *repo_model.Release)
NotifyUpdateRelease(doer *user_model.User, rel *repo_model.Release)
NotifyDeleteRelease(doer *user_model.User, rel *repo_model.Release)
NotifyPushCommits(pusher *user_model.User, repo *repo_model.Repository, opts *repository.PushUpdateOptions, commits *repository.PushCommits)
NotifyCreateRef(doer *user_model.User, repo *repo_model.Repository, refType, refFullName, refID string)
NotifyDeleteRef(doer *user_model.User, repo *repo_model.Repository, refType, refFullName string)
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.