Skip to content

Implement sync push mirror on commit #19411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jul 8, 2022
Merged

Implement sync push mirror on commit #19411

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
ac61c17
Update pushmirror model to allow sync-on-push
harryzcy Apr 15, 2022
04d7bd5
Move mirror push functions to a pushmirror service
harryzcy Apr 15, 2022
bd55411
Implement sync-on-push via a mirrorNotifier
harryzcy Apr 15, 2022
8f87595
Fix lint-backend issues
harryzcy Apr 15, 2022
eb25993
Add migration for PushMirror struct
harryzcy Apr 15, 2022
bcabe51
Improve filtering for push mirrors
harryzcy Apr 17, 2022
c6a4f30
Refactor to use modules/mirror
harryzcy Jun 3, 2022
2978942
Update tests after moving code to modules/mirror
harryzcy Jun 3, 2022
6c0e721
Include copyright
harryzcy Jun 3, 2022
0836473
Add 'sync on commit' checkbox in web UI
harryzcy Jun 29, 2022
5a8d2b5
Update checkbox input
harryzcy Jun 29, 2022
88f50e9
Store sync on commit setting
harryzcy Jun 29, 2022
c9d6393
Use more generic name SyncOnCommit
harryzcy Jun 29, 2022
f2de0a0
Trigger mirror on pull requests
harryzcy Jun 30, 2022
4c157e7
Merge remote-tracking branch 'upstream/main' into sync-on-push
harryzcy Jul 4, 2022
0f745bd
Fix table column name
harryzcy Jul 4, 2022
6f66d44
Update sync_on_commit column to false
harryzcy Jul 4, 2022
cb517b2
Make use of mirror queue
harryzcy Jul 4, 2022
3b0bd59
Use boolean keyword FALSE
harryzcy Jul 4, 2022
28925ad
Use False only for postgres
harryzcy Jul 4, 2022
436013e
Remove MergePullRequest event
harryzcy Jul 5, 2022
2bd23e6
Sync with mirror on SyncPushCommits event
harryzcy Jul 5, 2022
9cc7738
Remove unused context
harryzcy Jul 5, 2022
207e0fe
Fill input box with value
harryzcy Jul 5, 2022
08ceff9
Fix a func naming glitch in migration
harryzcy Jul 5, 2022
2cc1297
Apply not null and default to SyncOnCommit
harryzcy Jul 5, 2022
92603fc
Apply suggestions from code review
harryzcy Jul 5, 2022
67fa209
Fix minor errors from code review
harryzcy Jul 5, 2022
740408e
Enable sync on commit by default
harryzcy Jul 6, 2022
2210235
Set SyncOnCommit's default to true in models
harryzcy Jul 6, 2022
bc1afc1
Update comment to match function name
harryzcy Jul 7, 2022
6320a5d
Merge branch 'main' into sync-on-push
zeripath Jul 7, 2022
6aab911
Merge branch 'main' into sync-on-push
lunny Jul 8, 2022
b7331e9
Apply suggestions from code review
harryzcy Jul 8, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: delvh <dev.lh@web.de>
  • Loading branch information
@harryzcy @delvh
harryzcy and delvh authored Jul 8, 2022
commit b7331e9d7a9e13af8cadfb7745683bca09ee3dcc
3 changes: 1 addition & 2 deletions modules/mirror/mirror.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ func addMirrorToQueue(syncType SyncType, referenceID int64) {
return
}
go func() {
err := PushToQueue(syncType, referenceID)
if err != nil {
if err := PushToQueue(syncType, referenceID); err != nil {
log.Error("Unable to push sync request for to the queue for pull mirror repo[%d]. Error: %v", referenceID, err)
}
}()
Expand Down