Correctly handle moved files in apply patch #22118

zeripath · 2022-12-13T09:20:23Z

Moved files in a patch will result in git apply returning:

error: {filename}: No such file or directory

This wasn't handled by the git apply patch code. This PR adds handling for this.

Fix #22083

Signed-off-by: Andrew Thornton art27@cantab.net

Moved files in a patch will result in git apply returning: ``` error: {filename}: No such file or directory ``` This wasn't handled by the git apply patch code. This PR adds handling for this. Fix go-gitea#22083 Signed-off-by: Andrew Thornton <art27@cantab.net>

jtran · 2022-12-13T17:58:15Z

I ran into the same 500 error. The only difference is that the file on the target branch wasn't renamed; it was deleted. When I cherry-pick this change, it doesn't fix the 500 error. Can you verify the deleted case? It might actually be simpler to test since you don't need a file that git detects as a rename.

techknowlogick

temp blocking merge on this PR per @jtran's comment, feel free to remove this block as needed

zeripath · 2022-12-13T19:35:42Z

@jtran it would be really helpful to see the log message

jtran · 2022-12-13T19:40:59Z

@zeripath, this?

2022/12/13 12:43:49 [6398b9d5] router: started POST /jon/Archimajor/compare/main...jt/end-stops3 for 127.0.0.1:63122 2022/12/13 12:43:49 ...ices/auth/session.go:51:SessionUser() [T] [6398b9d5] Session Authorization: Found user[1] 2022/12/13 12:43:49 ...ices/auth/session.go:67:SessionUser() [T] [6398b9d5] Session Authorization: Logged in user 1:jon 2022/12/13 12:43:49 models/repo/repo.go:316:LoadUnits() [T] [6398b9d5] repo.Units, ID=1, Types: [TypeCode, TypeIssues, TypePullRequests, TypeReleases, TypeWiki, TypeProjects, TypePackages] 2022/12/13 12:43:49 ...s/repo_permission.go:157:func1() [T] [6398b9d5] Permission Loaded for 1:jon in 1:jon/Archimajor:	Permissions: perm_model.AccessMode: 4:owner, 7 Units, 0 UnitsMode(s): [	Units[0]: ID: 1 RepoID: 1 Type: 1:TypeCode Config: {}	Units[1]: ID: 2 RepoID: 1 Type: 2:TypeIssues Config: {"EnableTimetracker":false,"AllowOnlyContributorsToTrackTime":true,"EnableDependencies":true}	Units[2]: ID: 3 RepoID: 1 Type: 3:TypePullRequests Config: {"IgnoreWhitespaceConflicts":false,"AllowMerge":true,"AllowRebase":true,"AllowRebaseMerge":true,"AllowSquash":true,"AllowManualMerge":false,"AutodetectManualMerge":false,"AllowRebaseUpdate":true,"DefaultDeleteBranchAfterMerge":false,"DefaultMergeStyle":"merge"}	Units[3]: ID: 4 RepoID: 1 Type: 4:TypeReleases Config: {}	Units[4]: ID: 5 RepoID: 1 Type: 5:TypeWiki Config: {}	Units[5]: ID: 6 RepoID: 1 Type: 8:TypeProjects Config: {}	Units[6]: ID: 7 RepoID: 1 Type: 9:TypePackages Config: {} ] 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= rev-parse 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= cat-file --batch 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= show-ref --tags 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= cat-file --batch-check 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= show-ref --heads 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= cat-file -e main 2022/12/13 12:43:49 ...s/repo_permission.go:157:func1() [T] [6398b9d5] Permission Loaded for 1:jon in 1:jon/Archimajor:	Permissions: perm_model.AccessMode: 4:owner, 7 Units, 0 UnitsMode(s): [	Units[0]: ID: 1 RepoID: 1 Type: 1:TypeCode Config: {}	Units[1]: ID: 2 RepoID: 1 Type: 2:TypeIssues Config: {"EnableTimetracker":false,"AllowOnlyContributorsToTrackTime":true,"EnableDependencies":true}	Units[2]: ID: 3 RepoID: 1 Type: 3:TypePullRequests Config: {"IgnoreWhitespaceConflicts":false,"AllowMerge":true,"AllowRebase":true,"AllowRebaseMerge":true,"AllowSquash":true,"AllowManualMerge":false,"AutodetectManualMerge":false,"AllowRebaseUpdate":true,"DefaultDeleteBranchAfterMerge":false,"DefaultMergeStyle":"merge"}	Units[3]: ID: 4 RepoID: 1 Type: 4:TypeReleases Config: {}	Units[4]: ID: 5 RepoID: 1 Type: 5:TypeWiki Config: {}	Units[5]: ID: 6 RepoID: 1 Type: 8:TypeProjects Config: {}	Units[6]: ID: 7 RepoID: 1 Type: 9:TypePackages Config: {} ] 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= cat-file -e jt/end-stops3 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= rev-parse refs/heads/jt/end-stops3 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= merge-base -- refs/heads/main refs/heads/jt/end-stops3 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= rev-parse refs/heads/main 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= log 35a9e8a31fdb86b969d6a93f663a5d43a4143220...refs/heads/jt/end-stops3 --pretty=format:%H 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= diff -z --name-only refs/heads/main...refs/heads/jt/end-stops3 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5] /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= show-ref --heads 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= init 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= remote add -t main -m main origin /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= fetch origin --no-tags -- main:base main:original_base 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= symbolic-ref HEAD refs/heads/base 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= remote add head_repo /Users/myusername/gitea-data-1.17/repositories/jon/archimajor.git 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= fetch --no-tags head_repo refs/heads/jt/end-stops3:tracking 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= rev-parse 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= merge-base -- base tracking 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= cat-file --batch-check 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= cat-file --batch 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= read-tree -m 35a9e8a31fdb86b969d6a93f663a5d43a4143220 base tracking 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= ls-files -u -z 2022/12/13 12:43:49 ...ll/patch_unmerged.go:163:unmergedFiles() [T] [6398b9d5-15] Got line: 1 100644 EndStops.SchDoc 23ad8485b53eab033fd3049dbbaa6ab9a0349fc8 Current State:	<nil>	<nil>	<nil> 2022/12/13 12:43:49 ...ll/patch_unmerged.go:163:unmergedFiles() [T] [6398b9d5-15] Got line: 3 100644 EndStops.SchDoc 3c753e5ef5edb43a250534b1c113c8572dfc4ddb Current State:	1 100644 EndStops.SchDoc 23ad8485b53eab033fd3049dbbaa6ab9a0349fc8	<nil>	<nil> 2022/12/13 12:43:49 ...rvices/pull/patch.go:128:attemptMerge() [T] [6398b9d5-15] Attempt to merge:	1 100644 EndStops.SchDoc 23ad8485b53eab033fd3049dbbaa6ab9a0349fc8	<nil>	3 100644 EndStops.SchDoc 3c753e5ef5edb43a250534b1c113c8572dfc4ddb 2022/12/13 12:43:49 ...rvices/pull/patch.go:270:AttemptThreeWayMerge() [T] [6398b9d5-15] Conflict: EndStops.SchDoc in PR[0] jon/Archimajor#0 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= diff -p --binary --histogram 35a9e8a31fdb86b969d6a93f663a5d43a4143220 tracking 2022/12/13 12:43:49 ...rvices/pull/patch.go:348:checkConflicts() [T] [6398b9d5-15] PullRequest[0].testPatch (patchPath): /var/folders/sh/w_lwf0ss7gb34z423z30g9780000gn/T/patch1675702107 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= read-tree base 2022/12/13 12:43:49 ...dules/git/command.go:182:Run() [D] [6398b9d5-15] /Users/myusername/gitea/data/tmp/local-repo/pull.git3226040920: /opt/homebrew/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= apply --check --cached --3way /var/folders/sh/w_lwf0ss7gb34z423z30g9780000gn/T/patch1675702107 2022/12/13 12:43:49 ...ers/web/repo/pull.go:1244:CompareAndPullRequestPost() [E] NewPullRequest: git apply --check: exit status 1	/Users/myusername/gitea/routers/web/repo/pull.go:1244 (0x105c54574)	CompareAndPullRequestPost: ctx.ServerError("NewPullRequest", err)	/Users/myusername/gitea/modules/web/wrap_convert.go:47 (0x105a88ceb)	convertHandler.func3: t(ctx)	/Users/myusername/gitea/modules/web/wrap.go:41 (0x105a86e77)	wrapInternal.func1: done, deferrable := handler(resp, req, others...)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x10531412f)	(*Mux).routeHTTP: h.ServeHTTP(w, r)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/modules/web/wrap.go:63 (0x105a872f3)	Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/modules/web/wrap.go:63 (0x105a872f3)	Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/modules/web/wrap.go:63 (0x105a872f3)	Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/get_head.go:37 (0x105ae3b0b)	GetHead.func1: next.ServeHTTP(w, r)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/modules/web/wrap.go:63 (0x105a872f3)	Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/modules/context/context.go:838 (0x1056bced7)	Contexter.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x105312037)	(*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x10531393f)	(*Mux).Mount.func1: handler.ServeHTTP(w, r)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x10531412f)	(*Mux).routeHTTP: h.ServeHTTP(w, r)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/routers/web/base.go:174 (0x105c939a7)	Recovery.func1.1: next.ServeHTTP(w, req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/gitea.com/go-chi/session@v0.0.0-20211218221615-e3605d8b28b8/session.go:257 (0x1051abe5f)	Sessioner.func1.1: next.ServeHTTP(w, req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/modules/web/wrap.go:110 (0x105a87d77)	WrapWithPrefix.func1.1: next.ServeHTTP(resp, req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x105312037)	(*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x10531393f)	(*Mux).Mount.func1: handler.ServeHTTP(w, r)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x10531412f)	(*Mux).routeHTTP: h.ServeHTTP(w, r)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/routers/common/middleware.go:79 (0x105ae89fb)	Middlewares.func2.1: next.ServeHTTP(resp, req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/modules/context/access_log.go:38 (0x1056b1d33)	AccessLogger.func1.1: next.ServeHTTP(w, r)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/modules/web/routing/logger_manager.go:123 (0x105a8298f)	(*requestRecordsManager).handler.func1: next.ServeHTTP(w, req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/strip.go:30 (0x105ae62db)	StripSlashes.func1: next.ServeHTTP(w, r)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x105ae30f7)	ForwardedHeaders.func1.1: h.ServeHTTP(w, r)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/gitea/routers/common/middleware.go:32 (0x105ae8863)	Middlewares.func1.1: next.ServeHTTP(context.NewResponse(resp), req.WithContext(ctx))	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2084 (0x1046dff7b)	HandlerFunc.ServeHTTP: f(w, r)	/Users/myusername/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:88 (0x105311ff3)	(*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)	/Users/myusername/gitea/modules/web/route.go:200 (0x105a86373)	(*Route).ServeHTTP: r.R.ServeHTTP(w, req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:2916 (0x1046e313b)	serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)	/Users/myusername/sdk/go1.18.8/src/net/http/server.go:1966 (0x1046decbb)	(*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)	/Users/myusername/sdk/go1.18.8/src/runtime/asm_arm64.s:1270 (0x104280643)	goexit: MOVD	R0, R0	// NOP 2022/12/13 12:43:49 ...s/context/context.go:220:HTML() [D] Template: status/500 2022/12/13 12:43:49 router: completed POST /jon/Archimajor/compare/main...jt/end-stops3 for 127.0.0.1:63122, 500 Internal Server Error in 365.2ms @ repo/pull.go:1126(repo.CompareAndPullRequestPost) 2022/12/13 12:43:49 [6398b9d5-31] router: started GET /assets/css/index.css?v=1.17.3~45-gddf1c5857 for 127.0.0.1:63122 2022/12/13 12:43:49 [6398b9d5-31] router: completed GET /assets/css/index.css?v=1.17.3~45-gddf1c5857 for 127.0.0.1:63122, 200 OK in 0.8ms @ public/public.go:42(AssetsHandler) 2022/12/13 12:43:49 [6398b9d5-32] router: started GET /assets/css/theme-auto.css?v=1.17.3~45-gddf1c5857 for 127.0.0.1:63124 2022/12/13 12:43:49 [6398b9d5-32] router: completed GET /assets/css/theme-auto.css?v=1.17.3~45-gddf1c5857 for 127.0.0.1:63124, 200 OK in 0.2ms @ public/public.go:42(AssetsHandler) 2022/12/13 12:43:49 [6398b9d5-33] router: started GET /assets/js/index.js?v=1.17.3~45-gddf1c5857 for 127.0.0.1:63124 2022/12/13 12:43:49 [6398b9d5-34] router: started GET /assets/img/logo.svg for 127.0.0.1:63122 2022/12/13 12:43:49 [6398b9d5-34] router: completed GET /assets/img/logo.svg for 127.0.0.1:63122, 200 OK in 0.4ms @ public/public.go:42(AssetsHandler) 2022/12/13 12:43:49 [6398b9d5-33] router: completed GET /assets/js/index.js?v=1.17.3~45-gddf1c5857 for 127.0.0.1:63124, 200 OK in 1.3ms @ public/public.go:42(AssetsHandler) 2022/12/13 12:43:49 [6398b9d5-35] router: started GET /avatars/00388ce725e6886f3e07c3733007289b?size=72 for 127.0.0.1:63124 2022/12/13 12:43:49 [6398b9d5-36] router: started GET /assets/img/500.png for 127.0.0.1:63122 2022/12/13 12:43:49 [6398b9d5-36] router: completed GET /assets/img/500.png for 127.0.0.1:63122, 200 OK in 0.3ms @ public/public.go:42(AssetsHandler) 2022/12/13 12:43:49 [6398b9d5-35] router: completed GET /avatars/00388ce725e6886f3e07c3733007289b?size=72 for 127.0.0.1:63124, 200 OK in 0.6ms @ web/base.go:29(avatars)

jtran · 2022-12-13T20:18:23Z

I wanted to see what git was outputting. I added a log statement in step 8 of checkConflicts() here:

for scanner.Scan() { line := scanner.Text() log.Warn("***************** line=%q", line)

This is what I got. Only one line:

2022/12/13 15:15:33 ...rvices/pull/patch.go:419:func3() [W] [6398dd65-30] ***************** line="error: EndStops.SchDoc: does not exist in index"

Not sure if it's relevant, but I just upgraded to git 2.39.0. I was originally on git 2.38.1 when I got the error, so both versions have the problem.

Update: Changing the message ": No such file or directory", → ": does not exist in index", fixes the error for me for when the file is deleted on the target branch.

Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath · 2022-12-13T22:36:27Z

Thanks!

I've added a log.Trace where you added the temporary log.Warn and added the "does not exist in index" suffix too.

lunny · 2022-12-14T13:45:20Z

make L-G-T-M work

Backport go-gitea#22118 Moved files in a patch will result in git apply returning: ``` error: {filename}: No such file or directory ``` This wasn't handled by the git apply patch code. This PR adds handling for this. Fix go-gitea#22083 Signed-off-by: Andrew Thornton <art27@cantab.net>

Backport #22118 Moved files in a patch will result in git apply returning: ``` error: {filename}: No such file or directory ``` This wasn't handled by the git apply patch code. This PR adds handling for this. Fix #22083 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* upstream/main: Fixed Project view .board-column height for tall screens. (go-gitea#22108) Correctly handle moved files in apply patch (go-gitea#22118) remove duplicated read file code (go-gitea#22042) Fix condition for is_internal (go-gitea#22095) Make gitea work using cmd.exe again (go-gitea#22073) Fix markdown typo of an extra backtick in docs (go-gitea#22123) Fix autofilled text visibility in dark mode (go-gitea#22088)

Backport #22118 Moved files in a patch will result in git apply returning: ``` error: {filename}: No such file or directory ``` This wasn't handled by the git apply patch code. This PR adds handling for this. Fix #22083 Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gitea/gitea](https://github.com/go-gitea/gitea) | minor | `1.17.3-rootless` -> `1.18.5-rootless` | --- ### Release Notes <details> <summary>go-gitea/gitea</summary> ### [`v1.18.5`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1185-httpsgithubcomgo-giteagiteareleasestagv1185---2023-02-21) [Compare Source](go-gitea/gitea@v1.18.4...v1.18.5) - ENHANCEMENTS - Hide 2FA status from other members in organization members list ([#22999](go-gitea/gitea#22999)) ([#23023](go-gitea/gitea#23023)) - BUGFIXES - Add force_merge to merge request and fix checking mergable ([#23010](go-gitea/gitea#23010)) ([#23032](go-gitea/gitea#23032)) - Use `--message=%s` for git commit message ([#23028](go-gitea/gitea#23028)) ([#23029](go-gitea/gitea#23029)) - Render access log template as text instead of HTML ([#23013](go-gitea/gitea#23013)) ([#23025](go-gitea/gitea#23025)) - Fix the Manually Merged form ([#23015](go-gitea/gitea#23015)) ([#23017](go-gitea/gitea#23017)) - Use beforeCommit instead of baseCommit ([#22949](go-gitea/gitea#22949)) ([#22996](go-gitea/gitea#22996)) - Display attachments of review comment when comment content is blank ([#23035](go-gitea/gitea#23035)) ([#23046](go-gitea/gitea#23046)) - Return empty url for submodule tree entries ([#23043](go-gitea/gitea#23043)) ([#23048](go-gitea/gitea#23048)) ### [`v1.18.4`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1184-httpsgithubcomgo-giteagiteareleasestag1184---2023-02-20) [Compare Source](go-gitea/gitea@v1.18.3...v1.18.4) - SECURITY - Provide the ability to set password hash algorithm parameters ([#22942](go-gitea/gitea#22942)) ([#22943](go-gitea/gitea#22943)) - Add command to bulk set must-change-password ([#22823](go-gitea/gitea#22823)) ([#22928](go-gitea/gitea#22928)) - ENHANCEMENTS - Use import of OCI structs ([#22765](go-gitea/gitea#22765)) ([#22805](go-gitea/gitea#22805)) - Fix color of tertiary button on dark theme ([#22739](go-gitea/gitea#22739)) ([#22744](go-gitea/gitea#22744)) - Link issue and pull requests status change in UI notifications directly to their event in the timelined view. ([#22627](go-gitea/gitea#22627)) ([#22642](go-gitea/gitea#22642)) - BUGFIXES - Notify on container image create ([#22806](go-gitea/gitea#22806)) ([#22965](go-gitea/gitea#22965)) - Fix blame view missing lines ([#22826](go-gitea/gitea#22826)) ([#22929](go-gitea/gitea#22929)) - Fix incorrect role labels for migrated issues and comments ([#22914](go-gitea/gitea#22914)) ([#22923](go-gitea/gitea#22923)) - Fix PR file tree folders no longer collapsing ([#22864](go-gitea/gitea#22864)) ([#22872](go-gitea/gitea#22872)) - Escape filename when assemble URL ([#22850](go-gitea/gitea#22850)) ([#22871](go-gitea/gitea#22871)) - Fix isAllowed of escapeStreamer ([#22814](go-gitea/gitea#22814)) ([#22837](go-gitea/gitea#22837)) - Load issue before accessing index in merge message ([#22822](go-gitea/gitea#22822)) ([#22830](go-gitea/gitea#22830)) - Improve trace logging for pulls and processes ([#22633](go-gitea/gitea#22633)) ([#22812](go-gitea/gitea#22812)) - Fix restore repo bug, clarify the problem of ForeignIndex ([#22776](go-gitea/gitea#22776)) ([#22794](go-gitea/gitea#22794)) - Add default user visibility to cli command "admin user create" ([#22750](go-gitea/gitea#22750)) ([#22760](go-gitea/gitea#22760)) - Escape path for the file list ([#22741](go-gitea/gitea#22741)) ([#22757](go-gitea/gitea#22757)) - Fix bugs with WebAuthn preventing sign in and registration. ([#22651](go-gitea/gitea#22651)) ([#22721](go-gitea/gitea#22721)) - Add missing close bracket in imagediff ([#22710](go-gitea/gitea#22710)) ([#22712](go-gitea/gitea#22712)) - Move code comments to a standalone file and fix the bug when adding a reply to an outdated review appears to not post([#20821](go-gitea/gitea#20821)) ([#22707](go-gitea/gitea#22707)) - Fix line spacing for plaintext previews ([#22699](go-gitea/gitea#22699)) ([#22701](go-gitea/gitea#22701)) - Fix wrong hint when deleting a branch successfully from pull request UI ([#22673](go-gitea/gitea#22673)) ([#22698](go-gitea/gitea#22698)) - Fix README TOC links ([#22577](go-gitea/gitea#22577)) ([#22677](go-gitea/gitea#22677)) - Fix missing message in git hook when pull requests disabled on fork ([#22625](go-gitea/gitea#22625)) ([#22658](go-gitea/gitea#22658)) - Improve checkIfPRContentChanged ([#22611](go-gitea/gitea#22611)) ([#22644](go-gitea/gitea#22644)) - Prevent duplicate labels when importing more than 99 ([#22591](go-gitea/gitea#22591)) ([#22598](go-gitea/gitea#22598)) - Don't return duplicated users who can create org repo ([#22560](go-gitea/gitea#22560)) ([#22562](go-gitea/gitea#22562)) - BUILD - Upgrade golangcilint to v1.51.0 ([#22764](go-gitea/gitea#22764)) - MISC - Use proxy for pull mirror ([#22771](go-gitea/gitea#22771)) ([#22772](go-gitea/gitea#22772)) - Use `--index-url` in PyPi description ([#22620](go-gitea/gitea#22620)) ([#22636](go-gitea/gitea#22636)) ### [`v1.18.3`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1183-httpsgithubcomgo-giteagiteareleasestagv1183---2023-01-23) [Compare Source](go-gitea/gitea@v1.18.2...v1.18.3) - SECURITY - Prevent multiple `To` recipients ([#22566](go-gitea/gitea#22566)) ([#22569](go-gitea/gitea#22569)) - BUGFIXES - Truncate commit summary on repo files table. ([#22551](go-gitea/gitea#22551)) ([#22552](go-gitea/gitea#22552)) - Mute all links in issue timeline ([#22534](go-gitea/gitea#22534)) ### [`v1.18.2`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1182-httpsgithubcomgo-giteagiteareleasestagv1182---2023-01-19) [Compare Source](go-gitea/gitea@v1.18.1...v1.18.2) - BUGFIXES - Fix issue not auto-closing when it includes a reference to a branch ([#22514](go-gitea/gitea#22514)) ([#22521](go-gitea/gitea#22521)) - Fix invalid issue branch reference if not specified in template ([#22513](go-gitea/gitea#22513)) ([#22520](go-gitea/gitea#22520)) - Fix 500 error viewing pull request when fork has pull requests disabled ([#22512](go-gitea/gitea#22512)) ([#22515](go-gitea/gitea#22515)) - Reliable selection of admin user ([#22509](go-gitea/gitea#22509)) ([#22511](go-gitea/gitea#22511)) - Set disable_gravatar/enable_federated_avatar when offline mode is true ([#22479](go-gitea/gitea#22479)) ([#22496](go-gitea/gitea#22496)) - BUILD - cgo cross-compile for freebsd ([#22397](go-gitea/gitea#22397)) ([#22519](go-gitea/gitea#22519)) ### [`v1.18.1`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1181-httpsgithubcomgo-giteagiteareleasestagv1181---2023-01-17) [Compare Source](go-gitea/gitea@v1.18.0...v1.18.1) - API - Add `sync_on_commit` option for push mirrors api ([#22271](go-gitea/gitea#22271)) ([#22292](go-gitea/gitea#22292)) - BUGFIXES - Update `github.com/zeripath/zapx/v15` ([#22485](go-gitea/gitea#22485)) - Fix pull request API field `closed_at` always being `null` ([#22482](go-gitea/gitea#22482)) ([#22483](go-gitea/gitea#22483)) - Fix container blob mount ([#22226](go-gitea/gitea#22226)) ([#22476](go-gitea/gitea#22476)) - Fix error when calculating repository size ([#22392](go-gitea/gitea#22392)) ([#22474](go-gitea/gitea#22474)) - Fix Operator does not exist bug on explore page with ONLY_SHOW_RELEVANT_REPOS ([#22454](go-gitea/gitea#22454)) ([#22472](go-gitea/gitea#22472)) - Fix environments for KaTeX and error reporting ([#22453](go-gitea/gitea#22453)) ([#22473](go-gitea/gitea#22473)) - Remove the netgo tag for Windows build ([#22467](go-gitea/gitea#22467)) ([#22468](go-gitea/gitea#22468)) - Fix migration from GitBucket ([#22477](go-gitea/gitea#22477)) ([#22465](go-gitea/gitea#22465)) - Prevent panic on looking at api "git" endpoints for empty repos ([#22457](go-gitea/gitea#22457)) ([#22458](go-gitea/gitea#22458)) - Fix PR status layout on mobile ([#21547](go-gitea/gitea#21547)) ([#22441](go-gitea/gitea#22441)) - Fix wechatwork webhook sends empty content in PR review ([#21762](go-gitea/gitea#21762)) ([#22440](go-gitea/gitea#22440)) - Remove duplicate "Actions" label in mobile view ([#21974](go-gitea/gitea#21974)) ([#22439](go-gitea/gitea#22439)) - Fix leaving organization bug on user settings -> orgs ([#21983](go-gitea/gitea#21983)) ([#22438](go-gitea/gitea#22438)) - Fixed colour transparency regex matching in project board sorting ([#22092](go-gitea/gitea#22092)) ([#22437](go-gitea/gitea#22437)) - Correctly handle select on multiple channels in Queues ([#22146](go-gitea/gitea#22146)) ([#22428](go-gitea/gitea#22428)) - Prepend refs/heads/ to issue template refs ([#20461](go-gitea/gitea#20461)) ([#22427](go-gitea/gitea#22427)) - Restore function to "Show more" buttons ([#22399](go-gitea/gitea#22399)) ([#22426](go-gitea/gitea#22426)) - Continue GCing other repos on error in one repo ([#22422](go-gitea/gitea#22422)) ([#22425](go-gitea/gitea#22425)) - Allow HOST has no port ([#22280](go-gitea/gitea#22280)) ([#22409](go-gitea/gitea#22409)) - Fix omit avatar_url in discord payload when empty ([#22393](go-gitea/gitea#22393)) ([#22394](go-gitea/gitea#22394)) - Don't display stop watch top bar icon when disabled and hidden when click other place ([#22374](go-gitea/gitea#22374)) ([#22387](go-gitea/gitea#22387)) - Don't lookup mail server when using sendmail ([#22300](go-gitea/gitea#22300)) ([#22383](go-gitea/gitea#22383)) - Fix gravatar disable bug ([#22337](go-gitea/gitea#22337)) - Fix update settings table on install ([#22326](go-gitea/gitea#22326)) ([#22327](go-gitea/gitea#22327)) - Fix sitemap ([#22272](go-gitea/gitea#22272)) ([#22320](go-gitea/gitea#22320)) - Fix code search title translation ([#22285](go-gitea/gitea#22285)) ([#22316](go-gitea/gitea#22316)) - Fix due date rendering the wrong date in issue ([#22302](go-gitea/gitea#22302)) ([#22306](go-gitea/gitea#22306)) - Fix get system setting bug when enabled redis cache ([#22298](go-gitea/gitea#22298)) - Fix bug of DisableGravatar default value ([#22297](go-gitea/gitea#22297)) - Fix key signature error page ([#22229](go-gitea/gitea#22229)) ([#22230](go-gitea/gitea#22230)) - TESTING - Remove test session cache to reduce possible concurrent problem ([#22199](go-gitea/gitea#22199)) ([#22429](go-gitea/gitea#22429)) - MISC - Restore previous official review when an official review is deleted ([#22449](go-gitea/gitea#22449)) ([#22460](go-gitea/gitea#22460)) - Log STDERR of external renderer when it fails ([#22442](go-gitea/gitea#22442)) ([#22444](go-gitea/gitea#22444)) ### [`v1.18.0`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1180-httpsgithubcomgo-giteagiteareleasestagv1180---2022-12-29) [Compare Source](go-gitea/gitea@v1.17.4...v1.18.0) - SECURITY - Remove ReverseProxy authentication from the API ([#22219](go-gitea/gitea#22219)) ([#22251](go-gitea/gitea#22251)) - Support Go Vulnerability Management ([#21139](go-gitea/gitea#21139)) - Forbid HTML string tooltips ([#20935](go-gitea/gitea#20935)) - BREAKING - Rework mailer settings ([#18982](go-gitea/gitea#18982)) - Remove U2F support ([#20141](go-gitea/gitea#20141)) - Refactor `i18n` to `locale` ([#20153](go-gitea/gitea#20153)) - Enable contenthash in filename for dynamic assets ([#20813](go-gitea/gitea#20813)) - FEATURES - Add color previews in markdown ([#21474](go-gitea/gitea#21474)) - Allow package version sorting ([#21453](go-gitea/gitea#21453)) - Add support for Chocolatey/NuGet v2 API ([#21393](go-gitea/gitea#21393)) - Add API endpoint to get changed files of a PR ([#21177](go-gitea/gitea#21177)) - Add filetree on left of diff view ([#21012](go-gitea/gitea#21012)) - Support Issue forms and PR forms ([#20987](go-gitea/gitea#20987)) - Add support for Vagrant packages ([#20930](go-gitea/gitea#20930)) - Add support for `npm unpublish` ([#20688](go-gitea/gitea#20688)) - Add badge capabilities to users ([#20607](go-gitea/gitea#20607)) - Add issue filter for Author ([#20578](go-gitea/gitea#20578)) - Add KaTeX rendering to Markdown. ([#20571](go-gitea/gitea#20571)) - Add support for Pub packages ([#20560](go-gitea/gitea#20560)) - Support localized README ([#20508](go-gitea/gitea#20508)) - Add support mCaptcha as captcha provider ([#20458](go-gitea/gitea#20458)) - Add team member invite by email ([#20307](go-gitea/gitea#20307)) - Added email notification option to receive all own messages ([#20179](go-gitea/gitea#20179)) - Switch Unicode Escaping to a VSCode-like system ([#19990](go-gitea/gitea#19990)) - Add user/organization code search ([#19977](go-gitea/gitea#19977)) - Only show relevant repositories on explore page ([#19361](go-gitea/gitea#19361)) - User keypairs and HTTP signatures for ActivityPub federation using go-ap ([#19133](go-gitea/gitea#19133)) - Add sitemap support ([#18407](go-gitea/gitea#18407)) - Allow creation of OAuth2 applications for orgs ([#18084](go-gitea/gitea#18084)) - Add system setting table with cache and also add cache supports for user setting ([#18058](go-gitea/gitea#18058)) - Add pages to view watched repos and subscribed issues/PRs ([#17156](go-gitea/gitea#17156)) - Support Proxy protocol ([#12527](go-gitea/gitea#12527)) - Implement sync push mirror on commit ([#19411](go-gitea/gitea#19411)) - API - Allow empty assignees on pull request edit ([#22150](go-gitea/gitea#22150)) ([#22214](go-gitea/gitea#22214)) - Make external issue tracker regexp configurable via API ([#21338](go-gitea/gitea#21338)) - Add name field for org api ([#21270](go-gitea/gitea#21270)) - Show teams with no members if user is admin ([#21204](go-gitea/gitea#21204)) - Add latest commit's SHA to content response ([#20398](go-gitea/gitea#20398)) - Add allow_rebase_update, default_delete_branch_after_merge to repository api response ([#20079](go-gitea/gitea#20079)) - Add new endpoints for push mirrors management ([#19841](go-gitea/gitea#19841)) - ENHANCEMENTS - Add setting to disable the git apply step in test patch ([#22130](go-gitea/gitea#22130)) ([#22170](go-gitea/gitea#22170)) - Multiple improvements for comment edit diff ([#21990](go-gitea/gitea#21990)) ([#22007](go-gitea/gitea#22007)) - Fix button in branch list, avoid unexpected page jump before restore branch actually done ([#21562](go-gitea/gitea#21562)) ([#21928](go-gitea/gitea#21928)) - Fix flex layout for repo list icons ([#21896](go-gitea/gitea#21896)) ([#21920](go-gitea/gitea#21920)) - Fix vertical align of committer avatar rendered by email address ([#21884](go-gitea/gitea#21884)) ([#21918](go-gitea/gitea#21918)) - Fix setting HTTP headers after write ([#21833](go-gitea/gitea#21833)) ([#21877](go-gitea/gitea#21877)) - Color and Style enhancements ([#21784](go-gitea/gitea#21784), [#21799](go-gitea/gitea#21799)) ([#21868](go-gitea/gitea#21868)) - Ignore line anchor links with leading zeroes ([#21728](go-gitea/gitea#21728)) ([#21776](go-gitea/gitea#21776)) - Quick fixes monaco-editor error: "vs.editor.nullLanguage" ([#21734](go-gitea/gitea#21734)) ([#21738](go-gitea/gitea#21738)) - Use CSS color-scheme instead of invert ([#21616](go-gitea/gitea#21616)) ([#21623](go-gitea/gitea#21623)) - Respect user's locale when rendering the date range in the repo activity page ([#21410](go-gitea/gitea#21410)) - Change `commits-table` column width ([#21564](go-gitea/gitea#21564)) - Refactor git command arguments and make all arguments to be safe to be used ([#21535](go-gitea/gitea#21535)) - CSS color enhancements ([#21534](go-gitea/gitea#21534)) - Add link to user profile in markdown mention only if user exists ([#21533](go-gitea/gitea#21533), [#21554](go-gitea/gitea#21554)) - Add option to skip index dirs ([#21501](go-gitea/gitea#21501)) - Diff file tree tweaks ([#21446](go-gitea/gitea#21446)) - Localize all timestamps ([#21440](go-gitea/gitea#21440)) - Add `code` highlighting in issue titles ([#21432](go-gitea/gitea#21432)) - Use Name instead of DisplayName in LFS Lock ([#21415](go-gitea/gitea#21415)) - Consolidate more CSS colors into variables ([#21402](go-gitea/gitea#21402)) - Redirect to new repository owner ([#21398](go-gitea/gitea#21398)) - Use ISO date format instead of hard-coded English date format for date range in repo activity page ([#21396](go-gitea/gitea#21396)) - Use weighted algorithm for string matching when finding files in repo ([#21370](go-gitea/gitea#21370)) - Show private data in feeds ([#21369](go-gitea/gitea#21369)) - Refactor parseTreeEntries, speed up tree list ([#21368](go-gitea/gitea#21368)) - Add GET and DELETE endpoints for Docker blob uploads ([#21367](go-gitea/gitea#21367)) - Add nicer error handling on template compile errors ([#21350](go-gitea/gitea#21350)) - Add `stat` to `ToCommit` function for speed ([#21337](go-gitea/gitea#21337)) - Support instance-wide OAuth2 applications ([#21335](go-gitea/gitea#21335)) - Record OAuth client type at registration ([#21316](go-gitea/gitea#21316)) - Add new CSS variables --color-accent and --color-small-accent ([#21305](go-gitea/gitea#21305)) - Improve error descriptions for unauthorized_client ([#21292](go-gitea/gitea#21292)) - Case-insensitive "find files in repo" ([#21269](go-gitea/gitea#21269)) - Consolidate more CSS rules, fix inline code on arc-green ([#21260](go-gitea/gitea#21260)) - Log real ip of requests from ssh ([#21216](go-gitea/gitea#21216)) - Save files in local storage as group readable ([#21198](go-gitea/gitea#21198)) - Enable fluid page layout on medium size viewports ([#21178](go-gitea/gitea#21178)) - File header tweaks ([#21175](go-gitea/gitea#21175)) - Added missing headers on user packages page ([#21172](go-gitea/gitea#21172)) - Display image digest for container packages ([#21170](go-gitea/gitea#21170)) - Skip dirty check for team forms ([#21154](go-gitea/gitea#21154)) - Keep path when creating a new branch ([#21153](https://github.com/go-gitea/gitea/issues/21153)) - Remove fomantic image module ([#21145](https://github.com/go-gitea/gitea/issues/21145)) - Make labels clickable in the comments section. ([#21137](https://github.com/go-gitea/gitea/issues/21137)) - Sort branches and tags by date descending ([#21136](https://github.com/go-gitea/gitea/issues/21136)) - Better repo API unit checks ([#21130](https://github.com/go-gitea/gitea/issues/21130)) - Improve commit status icons ([#21124](https://github.com/go-gitea/gitea/issues/21124)) - Limit length of repo description and repo url input fields ([#21119](https://github.com/go-gitea/gitea/issues/21119)) - Show .editorconfig errors in frontend ([#21088](https://github.com/go-gitea/gitea/issues/21088)) - Allow poster to choose reviewers ([#21084](https://github.com/go-gitea/gitea/issues/21084)) - Remove black labels and CSS cleanup ([#21003](https://github.com/go-gitea/gitea/issues/21003)) - Make e-mail sanity check more precise ([#20991](https://github.com/go-gitea/gitea/issues/20991)) - Use native inputs in whitespace dropdown ([#20980](https://github.com/go-gitea/gitea/issues/20980)) - Enhance package date display ([#20928](https://github.com/go-gitea/gitea/issues/20928)) - Display total blob size of a package version ([#20927](https://github.com/go-gitea/gitea/issues/20927)) - Show language name on hover ([#20923](https://github.com/go-gitea/gitea/issues/20923)) - Show instructions for all generic package files ([#20917](https://github.com/go-gitea/gitea/issues/20917)) - Refactor AssertExistsAndLoadBean to use generics ([#20797](https://github.com/go-gitea/gitea/issues/20797)) - Move the official website link at the footer of gitea ([#20777](https://github.com/go-gitea/gitea/issues/20777)) - Add support for full name in reverse proxy auth ([#20776](https://github.com/go-gitea/gitea/issues/20776)) - Remove useless JS operation for relative time tooltips ([#20756](https://github.com/go-gitea/gitea/issues/20756)) - Replace some icons with SVG ([#20741](https://github.com/go-gitea/gitea/issues/20741)) - Change commit status icons to SVG ([#20736](https://github.com/go-gitea/gitea/issues/20736)) - Improve single repo action for issue and pull requests ([#20730](https://github.com/go-gitea/gitea/issues/20730)) - Allow multiple files in generic packages ([#20661](https://github.com/go-gitea/gitea/issues/20661)) - Add option to create new issue from /issues page ([#20650](https://github.com/go-gitea/gitea/issues/20650)) - Background color of private list-items updated ([#20630](https://github.com/go-gitea/gitea/issues/20630)) - Added search input field to issue filter ([#20623](https://github.com/go-gitea/gitea/issues/20623)) - Increase default item listing size `ISSUE_PAGING_NUM` to 20 ([#20547](https://github.com/go-gitea/gitea/issues/20547)) - Modify milestone search keywords to be case insensitive again ([#20513](https://github.com/go-gitea/gitea/issues/20513)) - Show hint to link package to repo when viewing empty repo package list ([#20504](https://github.com/go-gitea/gitea/issues/20504)) - Add Tar ZSTD support ([#20493](https://github.com/go-gitea/gitea/issues/20493)) - Make code review checkboxes clickable ([#20481](https://github.com/go-gitea/gitea/issues/20481)) - Add "X-Gitea-Object-Type" header for GET `/raw/` & `/media/` API ([#20438](https://github.com/go-gitea/gitea/issues/20438)) - Display project in issue list ([#20434](https://github.com/go-gitea/gitea/issues/20434)) - Prepend commit message to template content when opening a new PR ([#20429](https://github.com/go-gitea/gitea/issues/20429)) - Replace fomantic popup module with tippy.js ([#20428](https://github.com/go-gitea/gitea/issues/20428)) - Allow to specify colors for text in markup ([#20363](https://github.com/go-gitea/gitea/issues/20363)) - Allow access to the Public Organization Member lists with minimal permissions ([#20330](https://github.com/go-gitea/gitea/issues/20330)) - Use default values when provided values are empty ([#20318](https://github.com/go-gitea/gitea/issues/20318)) - Vertical align navbar avatar at middle ([#20302](https://github.com/go-gitea/gitea/issues/20302)) - Delete cancel button in repo creation page ([#21381](https://github.com/go-gitea/gitea/issues/21381)) - Include login_name in adminCreateUser response ([#20283](https://github.com/go-gitea/gitea/issues/20283)) - fix: icon margin in user/settings/repos ([#20281](https://github.com/go-gitea/gitea/issues/20281)) - Remove blue text on migrate page ([#20273](https://github.com/go-gitea/gitea/issues/20273)) - Modify milestone search keywords to be case insensitive ([#20266](https://github.com/go-gitea/gitea/issues/20266)) - Move some files into models' sub packages ([#20262](https://github.com/go-gitea/gitea/issues/20262)) - Add tooltip to repo icons in explore page ([#20241](https://github.com/go-gitea/gitea/issues/20241)) - Remove deprecated licenses ([#20222](https://github.com/go-gitea/gitea/issues/20222)) - Webhook for Wiki changes ([#20219](https://github.com/go-gitea/gitea/issues/20219)) - Share HTML template renderers and create a watcher framework ([#20218](https://github.com/go-gitea/gitea/issues/20218)) - Allow enable LDAP source and disable user sync via CLI ([#20206](https://github.com/go-gitea/gitea/issues/20206)) - Adds a checkbox to select all issues/PRs ([#20177](https://github.com/go-gitea/gitea/issues/20177)) - Refactor `i18n` to `locale` ([#20153](go-gitea/gitea#20153)) - Disable status checks in template if none found ([#20088](https://github.com/go-gitea/gitea/issues/20088)) - Allow manager logging to set SQL ([#20064](https://github.com/go-gitea/gitea/issues/20064)) - Add order by for assignee no sort issue ([#20053](https://github.com/go-gitea/gitea/issues/20053)) - Take a stab at porting existing components to Vue3 ([#20044](https://github.com/go-gitea/gitea/issues/20044)) - Add doctor command to write commit-graphs ([#20007](https://github.com/go-gitea/gitea/issues/20007)) - Add support for authentication based on reverse proxy email ([#19949](https://github.com/go-gitea/gitea/issues/19949)) - Enable spellcheck for EasyMDE, use contenteditable mode ([#19776](https://github.com/go-gitea/gitea/issues/19776)) - Allow specifying SECRET_KEY_URI, similar to INTERNAL_TOKEN_URI ([#19663](https://github.com/go-gitea/gitea/issues/19663)) - Rework mailer settings ([#18982](go-gitea/gitea#18982)) - Add option to purge users ([#18064](https://github.com/go-gitea/gitea/issues/18064)) - Add author search input ([#21246](https://github.com/go-gitea/gitea/issues/21246)) - Make rss/atom identifier globally unique ([#21550](https://github.com/go-gitea/gitea/issues/21550)) - BUGFIXES - Auth interface return error when verify failure ([#22119](https://github.com/go-gitea/gitea/issues/22119)) ([#22259](https://github.com/go-gitea/gitea/issues/22259)) - Use complete SHA to create and query commit status ([#22244](https://github.com/go-gitea/gitea/issues/22244)) ([#22257](https://github.com/go-gitea/gitea/issues/22257)) - Update bleve and zapx to fix unaligned atomic ([#22031](https://github.com/go-gitea/gitea/issues/22031)) ([#22218](https://github.com/go-gitea/gitea/issues/22218)) - Prevent panic in doctor command when running default checks ([#21791](https://github.com/go-gitea/gitea/issues/21791)) ([#21807](https://github.com/go-gitea/gitea/issues/21807)) - Load GitRepo in API before deleting issue ([#21720](https://github.com/go-gitea/gitea/issues/21720)) ([#21796](https://github.com/go-gitea/gitea/issues/21796)) - Ignore line anchor links with leading zeroes ([#21728](go-gitea/gitea#21728)) ([#21776](go-gitea/gitea#21776)) - Set last login when activating account ([#21731](https://github.com/go-gitea/gitea/issues/21731)) ([#21755](https://github.com/go-gitea/gitea/issues/21755)) - Fix UI language switching bug ([#21597](https://github.com/go-gitea/gitea/issues/21597)) ([#21749](https://github.com/go-gitea/gitea/issues/21749)) - Quick fixes monaco-editor error: "vs.editor.nullLanguage" ([#21734](go-gitea/gitea#21734)) ([#21738](go-gitea/gitea#21738)) - Allow local package identifiers for PyPI packages ([#21690](https://github.com/go-gitea/gitea/issues/21690)) ([#21727](https://github.com/go-gitea/gitea/issues/21727)) - Deal with markdown template without metadata ([#21639](https://github.com/go-gitea/gitea/issues/21639)) ([#21654](https://github.com/go-gitea/gitea/issues/21654)) - Fix opaque background on mermaid diagrams ([#21642](https://github.com/go-gitea/gitea/issues/21642)) ([#21652](https://github.com/go-gitea/gitea/issues/21652)) - Fix repository adoption on Windows ([#21646](https://github.com/go-gitea/gitea/issues/21646)) ([#21650](https://github.com/go-gitea/gitea/issues/21650)) - Sync git hooks when config file path changed ([#21619](https://github.com/go-gitea/gitea/issues/21619)) ([#21626](https://github.com/go-gitea/gitea/issues/21626)) - Fix 500 on PR files API ([#21602](https://github.com/go-gitea/gitea/issues/21602)) ([#21607](https://github.com/go-gitea/gitea/issues/21607)) - Fix `Timestamp.IsZero` ([#21593](https://github.com/go-gitea/gitea/issues/21593)) ([#21603](https://github.com/go-gitea/gitea/issues/21603)) - Fix viewing user subscriptions ([#21482](https://github.com/go-gitea/gitea/issues/21482)) - Fix mermaid-related bugs ([#21431](https://github.com/go-gitea/gitea/issues/21431)) - Fix branch dropdown shifting on page load ([#21428](https://github.com/go-gitea/gitea/issues/21428)) - Fix default theme-auto selector when nologin ([#21346](https://github.com/go-gitea/gitea/issues/21346)) - Fix and improve incorrect error messages ([#21342](https://github.com/go-gitea/gitea/issues/21342)) - Fix formatted link for PR review notifications to matrix ([#21319](https://github.com/go-gitea/gitea/issues/21319)) - Center-aligning content of WebAuthN page ([#21127](https://github.com/go-gitea/gitea/issues/21127)) - Remove follow from commits by file ([#20765](https://github.com/go-gitea/gitea/issues/20765)) - Fix commit status popup ([#20737](https://github.com/go-gitea/gitea/issues/20737)) - Fix init mail render logic ([#20704](https://github.com/go-gitea/gitea/issues/20704)) - Use correct page size for link header pagination ([#20546](https://github.com/go-gitea/gitea/issues/20546)) - Preserve unix socket file ([#20499](https://github.com/go-gitea/gitea/issues/20499)) - Use tippy.js for context popup ([#20393](https://github.com/go-gitea/gitea/issues/20393)) - Add missing parameter for error in log message ([#20144](https://github.com/go-gitea/gitea/issues/20144)) - Do not allow organisation owners add themselves as collaborator ([#20043](https://github.com/go-gitea/gitea/issues/20043)) - Rework file highlight rendering and fix yaml copy-paste ([#19967](https://github.com/go-gitea/gitea/issues/19967)) - Improve code diff highlight, fix incorrect rendered diff result ([#19958](https://github.com/go-gitea/gitea/issues/19958)) - TESTING - Improve OAuth integration tests ([#21390](https://github.com/go-gitea/gitea/issues/21390)) - Add playwright tests ([#20123](https://github.com/go-gitea/gitea/issues/20123)) - BUILD - Switch to building with go1.19 ([#20695](https://github.com/go-gitea/gitea/issues/20695)) - Update JS dependencies, adjust eslint ([#20659](https://github.com/go-gitea/gitea/issues/20659)) - Add more linters to improve code readability ([#19989](https://github.com/go-gitea/gitea/issues/19989)) ### [`v1.17.4`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1174-httpsgithubcomgo-giteagiteareleasestagv1174---2022-12-21) [Compare Source](go-gitea/gitea@v1.17.3...v1.17.4) - SECURITY - Do not allow Ghost access to limited visible user/org ([#21849](https://github.com/go-gitea/gitea/issues/21849)) ([#21875](https://github.com/go-gitea/gitea/issues/21875)) - Fix package access for admins and inactive users ([#21580](https://github.com/go-gitea/gitea/issues/21580)) ([#21592](https://github.com/go-gitea/gitea/issues/21592)) - ENHANCEMENTS - Fix button in branch list, avoid unexpected page jump before restore branch actually done ([#21562](go-gitea/gitea#21562)) ([#21927](https://github.com/go-gitea/gitea/issues/21927)) - Fix vertical align of committer avatar rendered by email address ([#21884](go-gitea/gitea#21884)) ([#21919](https://github.com/go-gitea/gitea/issues/21919)) - Fix setting HTTP headers after write ([#21833](go-gitea/gitea#21833)) ([#21874](https://github.com/go-gitea/gitea/issues/21874)) - Ignore line anchor links with leading zeroes ([#21728](go-gitea/gitea#21728)) ([#21777](https://github.com/go-gitea/gitea/issues/21777)) - Enable Monaco automaticLayout ([#21516](https://github.com/go-gitea/gitea/issues/21516)) - BUGFIXES - Do not list active repositories as unadopted ([#22034](https://github.com/go-gitea/gitea/issues/22034)) ([#22167](https://github.com/go-gitea/gitea/issues/22167)) - Correctly handle moved files in apply patch ([#22118](https://github.com/go-gitea/gitea/issues/22118)) ([#22136](https://github.com/go-gitea/gitea/issues/22136)) - Fix condition for is_internal ([#22095](https://github.com/go-gitea/gitea/issues/22095)) ([#22131](https://github.com/go-gitea/gitea/issues/22131)) - Fix permission check on issue/pull lock ([#22114](https://github.com/go-gitea/gitea/issues/22114)) - Fix sorting admin user list by last login ([#22081](https://github.com/go-gitea/gitea/issues/22081)) ([#22106](https://github.com/go-gitea/gitea/issues/22106)) - Workaround for container registry push/pull errors ([#21862](https://github.com/go-gitea/gitea/issues/21862)) ([#22069](https://github.com/go-gitea/gitea/issues/22069)) - Fix issue/PR numbers ([#22037](https://github.com/go-gitea/gitea/issues/22037)) ([#22045](https://github.com/go-gitea/gitea/issues/22045)) - Handle empty author names ([#21902](https://github.com/go-gitea/gitea/issues/21902)) ([#22028](https://github.com/go-gitea/gitea/issues/22028)) - Fix ListBranches to handle empty case ([#21921](https://github.com/go-gitea/gitea/issues/21921)) ([#22025](https://github.com/go-gitea/gitea/issues/22025)) - Fix enabling partial clones on 1.17 ([#21809](https://github.com/go-gitea/gitea/issues/21809)) - Prevent panic in doctor command when running default checks ([#21791](https://github.com/go-gitea/gitea/issues/21791)) ([#21808](https://github.com/go-gitea/gitea/issues/21808)) - Upgrade golang.org/x/crypto ([#21792](https://github.com/go-gitea/gitea/issues/21792)) ([#21794](https://github.com/go-gitea/gitea/issues/21794)) - Init git module before database migration ([#21764](https://github.com/go-gitea/gitea/issues/21764)) ([#21766](https://github.com/go-gitea/gitea/issues/21766)) - Set last login when activating account ([#21731](https://github.com/go-gitea/gitea/issues/21731)) ([#21754](https://github.com/go-gitea/gitea/issues/21754)) - Add HEAD fix to gitea doctor ([#21352](https://github.com/go-gitea/gitea/issues/21352)) ([#21751](https://github.com/go-gitea/gitea/issues/21751)) - Fix UI language switching bug ([#21597](https://github.com/go-gitea/gitea/issues/21597)) ([#21748](https://github.com/go-gitea/gitea/issues/21748)) - Remove semver compatible flag and change pypi to an array of test cases ([#21708](https://github.com/go-gitea/gitea/issues/21708)) ([#21729](https://github.com/go-gitea/gitea/issues/21729)) - Allow local package identifiers for PyPI packages ([#21690](https://github.com/go-gitea/gitea/issues/21690)) ([#21726](https://github.com/go-gitea/gitea/issues/21726)) - Fix repository adoption on Windows ([#21646](https://github.com/go-gitea/gitea/issues/21646)) ([#21651](https://github.com/go-gitea/gitea/issues/21651)) - Sync git hooks when config file path changed ([#21619](https://github.com/go-gitea/gitea/issues/21619)) ([#21625](https://github.com/go-gitea/gitea/issues/21625)) - Added check for disabled Packages ([#21540](https://github.com/go-gitea/gitea/issues/21540)) ([#21614](https://github.com/go-gitea/gitea/issues/21614)) - Fix `Timestamp.IsZero` ([#21593](https://github.com/go-gitea/gitea/issues/21593)) ([#21604](https://github.com/go-gitea/gitea/issues/21604)) - Fix issues count bug ([#21600](https://github.com/go-gitea/gitea/issues/21600)) - Support binary deploy in npm packages ([#21589](https://github.com/go-gitea/gitea/issues/21589)) - Update milestone counters when issue is deleted ([#21459](https://github.com/go-gitea/gitea/issues/21459)) ([#21586](https://github.com/go-gitea/gitea/issues/21586)) - SessionUser protection against nil pointer dereference ([#21581](https://github.com/go-gitea/gitea/issues/21581)) - Case-insensitive NuGet symbol file GUID ([#21409](https://github.com/go-gitea/gitea/issues/21409)) ([#21575](https://github.com/go-gitea/gitea/issues/21575)) - Suppress `ExternalLoginUserNotExist` error ([#21504](https://github.com/go-gitea/gitea/issues/21504)) ([#21572](https://github.com/go-gitea/gitea/issues/21572)) - Prevent Authorization header for presigned LFS urls ([#21531](https://github.com/go-gitea/gitea/issues/21531)) ([#21569](https://github.com/go-gitea/gitea/issues/21569)) - Update binding to fix bugs ([#21560](https://github.com/go-gitea/gitea/issues/21560)) - Fix generating compare link ([#21519](https://github.com/go-gitea/gitea/issues/21519)) ([#21530](https://github.com/go-gitea/gitea/issues/21530)) - Ignore error when retrieving changed PR review files ([#21487](https://github.com/go-gitea/gitea/issues/21487)) ([#21524](https://github.com/go-gitea/gitea/issues/21524)) - Fix incorrect notification commit url ([#21479](https://github.com/go-gitea/gitea/issues/21479)) ([#21483](https://github.com/go-gitea/gitea/issues/21483)) - Display total commit count in hook message ([#21400](https://github.com/go-gitea/gitea/issues/21400)) ([#21481](https://github.com/go-gitea/gitea/issues/21481)) - Enforce grouped NuGet search results ([#21442](https://github.com/go-gitea/gitea/issues/21442)) ([#21480](https://github.com/go-gitea/gitea/issues/21480)) - Return 404 when user is not found on avatar ([#21476](https://github.com/go-gitea/gitea/issues/21476)) ([#21477](https://github.com/go-gitea/gitea/issues/21477)) - Normalize NuGet package version on upload ([#22186](https://github.com/go-gitea/gitea/issues/22186)) ([#22201](https://github.com/go-gitea/gitea/issues/22201)) - MISC - Check for zero time instant in TimeStamp.IsZero() ([#22171](https://github.com/go-gitea/gitea/issues/22171)) ([#22173](https://github.com/go-gitea/gitea/issues/22173)) - Fix warn in database structs sync ([#22111](https://github.com/go-gitea/gitea/issues/22111)) - Allow for resolution of NPM registry paths that match upstream ([#21568](https://github.com/go-gitea/gitea/issues/21568)) ([#21723](https://github.com/go-gitea/gitea/issues/21723)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Michael Wittig <michael.wittig@posteo.de> Reviewed-on: https://gitea.sh4ke.rocks/sh4ke/k8s-projects/pulls/85

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gitea/gitea](https://github.com/go-gitea/gitea) | minor | `1.17.3-rootless` -> `1.18.5-rootless` | --- ### Release Notes <details> <summary>go-gitea/gitea</summary> ### [`v1.18.5`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1185-httpsgithubcomgo-giteagiteareleasestagv1185---2023-02-21) [Compare Source](go-gitea/gitea@v1.18.4...v1.18.5) - ENHANCEMENTS - Hide 2FA status from other members in organization members list ([#22999](go-gitea/gitea#22999)) ([#23023](go-gitea/gitea#23023)) - BUGFIXES - Add force_merge to merge request and fix checking mergable ([#23010](go-gitea/gitea#23010)) ([#23032](go-gitea/gitea#23032)) - Use `--message=%s` for git commit message ([#23028](go-gitea/gitea#23028)) ([#23029](go-gitea/gitea#23029)) - Render access log template as text instead of HTML ([#23013](go-gitea/gitea#23013)) ([#23025](go-gitea/gitea#23025)) - Fix the Manually Merged form ([#23015](go-gitea/gitea#23015)) ([#23017](go-gitea/gitea#23017)) - Use beforeCommit instead of baseCommit ([#22949](go-gitea/gitea#22949)) ([#22996](go-gitea/gitea#22996)) - Display attachments of review comment when comment content is blank ([#23035](go-gitea/gitea#23035)) ([#23046](go-gitea/gitea#23046)) - Return empty url for submodule tree entries ([#23043](go-gitea/gitea#23043)) ([#23048](go-gitea/gitea#23048)) ### [`v1.18.4`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1184-httpsgithubcomgo-giteagiteareleasestag1184---2023-02-20) [Compare Source](go-gitea/gitea@v1.18.3...v1.18.4) - SECURITY - Provide the ability to set password hash algorithm parameters ([#22942](go-gitea/gitea#22942)) ([#22943](go-gitea/gitea#22943)) - Add command to bulk set must-change-password ([#22823](go-gitea/gitea#22823)) ([#22928](go-gitea/gitea#22928)) - ENHANCEMENTS - Use import of OCI structs ([#22765](go-gitea/gitea#22765)) ([#22805](go-gitea/gitea#22805)) - Fix color of tertiary button on dark theme ([#22739](go-gitea/gitea#22739)) ([#22744](go-gitea/gitea#22744)) - Link issue and pull requests status change in UI notifications directly to their event in the timelined view. ([#22627](go-gitea/gitea#22627)) ([#22642](go-gitea/gitea#22642)) - BUGFIXES - Notify on container image create ([#22806](go-gitea/gitea#22806)) ([#22965](go-gitea/gitea#22965)) - Fix blame view missing lines ([#22826](go-gitea/gitea#22826)) ([#22929](go-gitea/gitea#22929)) - Fix incorrect role labels for migrated issues and comments ([#22914](go-gitea/gitea#22914)) ([#22923](go-gitea/gitea#22923)) - Fix PR file tree folders no longer collapsing ([#22864](go-gitea/gitea#22864)) ([#22872](go-gitea/gitea#22872)) - Escape filename when assemble URL ([#22850](go-gitea/gitea#22850)) ([#22871](go-gitea/gitea#22871)) - Fix isAllowed of escapeStreamer ([#22814](go-gitea/gitea#22814)) ([#22837](go-gitea/gitea#22837)) - Load issue before accessing index in merge message ([#22822](go-gitea/gitea#22822)) ([#22830](go-gitea/gitea#22830)) - Improve trace logging for pulls and processes ([#22633](go-gitea/gitea#22633)) ([#22812](go-gitea/gitea#22812)) - Fix restore repo bug, clarify the problem of ForeignIndex ([#22776](go-gitea/gitea#22776)) ([#22794](go-gitea/gitea#22794)) - Add default user visibility to cli command "admin user create" ([#22750](go-gitea/gitea#22750)) ([#22760](go-gitea/gitea#22760)) - Escape path for the file list ([#22741](go-gitea/gitea#22741)) ([#22757](go-gitea/gitea#22757)) - Fix bugs with WebAuthn preventing sign in and registration. ([#22651](go-gitea/gitea#22651)) ([#22721](go-gitea/gitea#22721)) - Add missing close bracket in imagediff ([#22710](go-gitea/gitea#22710)) ([#22712](go-gitea/gitea#22712)) - Move code comments to a standalone file and fix the bug when adding a reply to an outdated review appears to not post([#20821](go-gitea/gitea#20821)) ([#22707](go-gitea/gitea#22707)) - Fix line spacing for plaintext previews ([#22699](go-gitea/gitea#22699)) ([#22701](go-gitea/gitea#22701)) - Fix wrong hint when deleting a branch successfully from pull request UI ([#22673](go-gitea/gitea#22673)) ([#22698](go-gitea/gitea#22698)) - Fix README TOC links ([#22577](go-gitea/gitea#22577)) ([#22677](go-gitea/gitea#22677)) - Fix missing message in git hook when pull requests disabled on fork ([#22625](go-gitea/gitea#22625)) ([#22658](go-gitea/gitea#22658)) - Improve checkIfPRContentChanged ([#22611](go-gitea/gitea#22611)) ([#22644](go-gitea/gitea#22644)) - Prevent duplicate labels when importing more than 99 ([#22591](go-gitea/gitea#22591)) ([#22598](go-gitea/gitea#22598)) - Don't return duplicated users who can create org repo ([#22560](go-gitea/gitea#22560)) ([#22562](go-gitea/gitea#22562)) - BUILD - Upgrade golangcilint to v1.51.0 ([#22764](go-gitea/gitea#22764)) - MISC - Use proxy for pull mirror ([#22771](go-gitea/gitea#22771)) ([#22772](go-gitea/gitea#22772)) - Use `--index-url` in PyPi description ([#22620](go-gitea/gitea#22620)) ([#22636](go-gitea/gitea#22636)) ### [`v1.18.3`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1183-httpsgithubcomgo-giteagiteareleasestagv1183---2023-01-23) [Compare Source](go-gitea/gitea@v1.18.2...v1.18.3) - SECURITY - Prevent multiple `To` recipients ([#22566](go-gitea/gitea#22566)) ([#22569](go-gitea/gitea#22569)) - BUGFIXES - Truncate commit summary on repo files table. ([#22551](go-gitea/gitea#22551)) ([#22552](go-gitea/gitea#22552)) - Mute all links in issue timeline ([#22534](go-gitea/gitea#22534)) ### [`v1.18.2`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1182-httpsgithubcomgo-giteagiteareleasestagv1182---2023-01-19) [Compare Source](go-gitea/gitea@v1.18.1...v1.18.2) - BUGFIXES - Fix issue not auto-closing when it includes a reference to a branch ([#22514](go-gitea/gitea#22514)) ([#22521](go-gitea/gitea#22521)) - Fix invalid issue branch reference if not specified in template ([#22513](go-gitea/gitea#22513)) ([#22520](go-gitea/gitea#22520)) - Fix 500 error viewing pull request when fork has pull requests disabled ([#22512](go-gitea/gitea#22512)) ([#22515](go-gitea/gitea#22515)) - Reliable selection of admin user ([#22509](go-gitea/gitea#22509)) ([#22511](go-gitea/gitea#22511)) - Set disable_gravatar/enable_federated_avatar when offline mode is true ([#22479](go-gitea/gitea#22479)) ([#22496](go-gitea/gitea#22496)) - BUILD - cgo cross-compile for freebsd ([#22397](go-gitea/gitea#22397)) ([#22519](go-gitea/gitea#22519)) ### [`v1.18.1`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1181-httpsgithubcomgo-giteagiteareleasestagv1181---2023-01-17) [Compare Source](go-gitea/gitea@v1.18.0...v1.18.1) - API - Add `sync_on_commit` option for push mirrors api ([#22271](go-gitea/gitea#22271)) ([#22292](go-gitea/gitea#22292)) - BUGFIXES - Update `github.com/zeripath/zapx/v15` ([#22485](go-gitea/gitea#22485)) - Fix pull request API field `closed_at` always being `null` ([#22482](go-gitea/gitea#22482)) ([#22483](go-gitea/gitea#22483)) - Fix container blob mount ([#22226](go-gitea/gitea#22226)) ([#22476](go-gitea/gitea#22476)) - Fix error when calculating repository size ([#22392](go-gitea/gitea#22392)) ([#22474](go-gitea/gitea#22474)) - Fix Operator does not exist bug on explore page with ONLY_SHOW_RELEVANT_REPOS ([#22454](go-gitea/gitea#22454)) ([#22472](go-gitea/gitea#22472)) - Fix environments for KaTeX and error reporting ([#22453](go-gitea/gitea#22453)) ([#22473](go-gitea/gitea#22473)) - Remove the netgo tag for Windows build ([#22467](go-gitea/gitea#22467)) ([#22468](go-gitea/gitea#22468)) - Fix migration from GitBucket ([#22477](go-gitea/gitea#22477)) ([#22465](go-gitea/gitea#22465)) - Prevent panic on looking at api "git" endpoints for empty repos ([#22457](go-gitea/gitea#22457)) ([#22458](go-gitea/gitea#22458)) - Fix PR status layout on mobile ([#21547](go-gitea/gitea#21547)) ([#22441](go-gitea/gitea#22441)) - Fix wechatwork webhook sends empty content in PR review ([#21762](go-gitea/gitea#21762)) ([#22440](go-gitea/gitea#22440)) - Remove duplicate "Actions" label in mobile view ([#21974](go-gitea/gitea#21974)) ([#22439](go-gitea/gitea#22439)) - Fix leaving organization bug on user settings -> orgs ([#21983](go-gitea/gitea#21983)) ([#22438](go-gitea/gitea#22438)) - Fixed colour transparency regex matching in project board sorting ([#22092](go-gitea/gitea#22092)) ([#22437](go-gitea/gitea#22437)) - Correctly handle select on multiple channels in Queues ([#22146](go-gitea/gitea#22146)) ([#22428](go-gitea/gitea#22428)) - Prepend refs/heads/ to issue template refs ([#20461](go-gitea/gitea#20461)) ([#22427](go-gitea/gitea#22427)) - Restore function to "Show more" buttons ([#22399](go-gitea/gitea#22399)) ([#22426](go-gitea/gitea#22426)) - Continue GCing other repos on error in one repo ([#22422](go-gitea/gitea#22422)) ([#22425](go-gitea/gitea#22425)) - Allow HOST has no port ([#22280](go-gitea/gitea#22280)) ([#22409](go-gitea/gitea#22409)) - Fix omit avatar_url in discord payload when empty ([#22393](go-gitea/gitea#22393)) ([#22394](go-gitea/gitea#22394)) - Don't display stop watch top bar icon when disabled and hidden when click other place ([#22374](go-gitea/gitea#22374)) ([#22387](go-gitea/gitea#22387)) - Don't lookup mail server when using sendmail ([#22300](go-gitea/gitea#22300)) ([#22383](go-gitea/gitea#22383)) - Fix gravatar disable bug ([#22337](go-gitea/gitea#22337)) - Fix update settings table on install ([#22326](go-gitea/gitea#22326)) ([#22327](go-gitea/gitea#22327)) - Fix sitemap ([#22272](go-gitea/gitea#22272)) ([#22320](go-gitea/gitea#22320)) - Fix code search title translation ([#22285](go-gitea/gitea#22285)) ([#22316](go-gitea/gitea#22316)) - Fix due date rendering the wrong date in issue ([#22302](go-gitea/gitea#22302)) ([#22306](go-gitea/gitea#22306)) - Fix get system setting bug when enabled redis cache ([#22298](go-gitea/gitea#22298)) - Fix bug of DisableGravatar default value ([#22297](go-gitea/gitea#22297)) - Fix key signature error page ([#22229](go-gitea/gitea#22229)) ([#22230](go-gitea/gitea#22230)) - TESTING - Remove test session cache to reduce possible concurrent problem ([#22199](go-gitea/gitea#22199)) ([#22429](go-gitea/gitea#22429)) - MISC - Restore previous official review when an official review is deleted ([#22449](go-gitea/gitea#22449)) ([#22460](go-gitea/gitea#22460)) - Log STDERR of external renderer when it fails ([#22442](go-gitea/gitea#22442)) ([#22444](go-gitea/gitea#22444)) ### [`v1.18.0`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1180-httpsgithubcomgo-giteagiteareleasestagv1180---2022-12-29) [Compare Source](go-gitea/gitea@v1.17.4...v1.18.0) - SECURITY - Remove ReverseProxy authentication from the API ([#22219](go-gitea/gitea#22219)) ([#22251](go-gitea/gitea#22251)) - Support Go Vulnerability Management ([#21139](go-gitea/gitea#21139)) - Forbid HTML string tooltips ([#20935](go-gitea/gitea#20935)) - BREAKING - Rework mailer settings ([#18982](go-gitea/gitea#18982)) - Remove U2F support ([#20141](go-gitea/gitea#20141)) - Refactor `i18n` to `locale` ([#20153](go-gitea/gitea#20153)) - Enable contenthash in filename for dynamic assets ([#20813](go-gitea/gitea#20813)) - FEATURES - Add color previews in markdown ([#21474](go-gitea/gitea#21474)) - Allow package version sorting ([#21453](go-gitea/gitea#21453)) - Add support for Chocolatey/NuGet v2 API ([#21393](go-gitea/gitea#21393)) - Add API endpoint to get changed files of a PR ([#21177](go-gitea/gitea#21177)) - Add filetree on left of diff view ([#21012](go-gitea/gitea#21012)) - Support Issue forms and PR forms ([#20987](go-gitea/gitea#20987)) - Add support for Vagrant packages ([#20930](go-gitea/gitea#20930)) - Add support for `npm unpublish` ([#20688](go-gitea/gitea#20688)) - Add badge capabilities to users ([#20607](go-gitea/gitea#20607)) - Add issue filter for Author ([#20578](go-gitea/gitea#20578)) - Add KaTeX rendering to Markdown. ([#20571](go-gitea/gitea#20571)) - Add support for Pub packages ([#20560](go-gitea/gitea#20560)) - Support localized README ([#20508](go-gitea/gitea#20508)) - Add support mCaptcha as captcha provider ([#20458](go-gitea/gitea#20458)) - Add team member invite by email ([#20307](go-gitea/gitea#20307)) - Added email notification option to receive all own messages ([#20179](go-gitea/gitea#20179)) - Switch Unicode Escaping to a VSCode-like system ([#19990](go-gitea/gitea#19990)) - Add user/organization code search ([#19977](go-gitea/gitea#19977)) - Only show relevant repositories on explore page ([#19361](go-gitea/gitea#19361)) - User keypairs and HTTP signatures for ActivityPub federation using go-ap ([#19133](go-gitea/gitea#19133)) - Add sitemap support ([#18407](go-gitea/gitea#18407)) - Allow creation of OAuth2 applications for orgs ([#18084](go-gitea/gitea#18084)) - Add system setting table with cache and also add cache supports for user setting ([#18058](go-gitea/gitea#18058)) - Add pages to view watched repos and subscribed issues/PRs ([#17156](go-gitea/gitea#17156)) - Support Proxy protocol ([#12527](go-gitea/gitea#12527)) - Implement sync push mirror on commit ([#19411](go-gitea/gitea#19411)) - API - Allow empty assignees on pull request edit ([#22150](go-gitea/gitea#22150)) ([#22214](go-gitea/gitea#22214)) - Make external issue tracker regexp configurable via API ([#21338](go-gitea/gitea#21338)) - Add name field for org api ([#21270](go-gitea/gitea#21270)) - Show teams with no members if user is admin ([#21204](go-gitea/gitea#21204)) - Add latest commit's SHA to content response ([#20398](go-gitea/gitea#20398)) - Add allow_rebase_update, default_delete_branch_after_merge to repository api response ([#20079](go-gitea/gitea#20079)) - Add new endpoints for push mirrors management ([#19841](go-gitea/gitea#19841)) - ENHANCEMENTS - Add setting to disable the git apply step in test patch ([#22130](go-gitea/gitea#22130)) ([#22170](go-gitea/gitea#22170)) - Multiple improvements for comment edit diff ([#21990](go-gitea/gitea#21990)) ([#22007](go-gitea/gitea#22007)) - Fix button in branch list, avoid unexpected page jump before restore branch actually done ([#21562](go-gitea/gitea#21562)) ([#21928](go-gitea/gitea#21928)) - Fix flex layout for repo list icons ([#21896](go-gitea/gitea#21896)) ([#21920](go-gitea/gitea#21920)) - Fix vertical align of committer avatar rendered by email address ([#21884](go-gitea/gitea#21884)) ([#21918](go-gitea/gitea#21918)) - Fix setting HTTP headers after write ([#21833](go-gitea/gitea#21833)) ([#21877](go-gitea/gitea#21877)) - Color and Style enhancements ([#21784](go-gitea/gitea#21784), [#21799](go-gitea/gitea#21799)) ([#21868](go-gitea/gitea#21868)) - Ignore line anchor links with leading zeroes ([#21728](go-gitea/gitea#21728)) ([#21776](go-gitea/gitea#21776)) - Quick fixes monaco-editor error: "vs.editor.nullLanguage" ([#21734](go-gitea/gitea#21734)) ([#21738](go-gitea/gitea#21738)) - Use CSS color-scheme instead of invert ([#21616](go-gitea/gitea#21616)) ([#21623](go-gitea/gitea#21623)) - Respect user's locale when rendering the date range in the repo activity page ([#21410](go-gitea/gitea#21410)) - Change `commits-table` column width ([#21564](go-gitea/gitea#21564)) - Refactor git command arguments and make all arguments to be safe to be used ([#21535](go-gitea/gitea#21535)) - CSS color enhancements ([#21534](go-gitea/gitea#21534)) - Add link to user profile in markdown mention only if user exists ([#21533](go-gitea/gitea#21533), [#21554](go-gitea/gitea#21554)) - Add option to skip index dirs ([#21501](go-gitea/gitea#21501)) - Diff file tree tweaks ([#21446](go-gitea/gitea#21446)) - Localize all timestamps ([#21440](go-gitea/gitea#21440)) - Add `code` highlighting in issue titles ([#21432](go-gitea/gitea#21432)) - Use Name instead of DisplayName in LFS Lock ([#21415](go-gitea/gitea#21415)) - Consolidate more CSS colors into variables ([#21402](go-gitea/gitea#21402)) - Redirect to new repository owner ([#21398](go-gitea/gitea#21398)) - Use ISO date format instead of hard-coded English date format for date range in repo activity page ([#21396](go-gitea/gitea#21396)) - Use weighted algorithm for string matching when finding files in repo ([#21370](go-gitea/gitea#21370)) - Show private data in feeds ([#21369](go-gitea/gitea#21369)) - Refactor parseTreeEntries, speed up tree list ([#21368](go-gitea/gitea#21368)) - Add GET and DELETE endpoints for Docker blob uploads ([#21367](go-gitea/gitea#21367)) - Add nicer error handling on template compile errors ([#21350](go-gitea/gitea#21350)) - Add `stat` to `ToCommit` function for speed ([#21337](go-gitea/gitea#21337)) - Support instance-wide OAuth2 applications ([#21335](go-gitea/gitea#21335)) - Record OAuth client type at registration ([#21316](go-gitea/gitea#21316)) - Add new CSS variables --color-accent and --color-small-accent ([#21305](go-gitea/gitea#21305)) - Improve error descriptions for unauthorized_client ([#21292](go-gitea/gitea#21292)) - Case-insensitive "find files in repo" ([#21269](go-gitea/gitea#21269)) - Consolidate more CSS rules, fix inline code on arc-green ([#21260](go-gitea/gitea#21260)) - Log real ip of requests from ssh ([#21216](go-gitea/gitea#21216)) - Save files in local storage as group readable ([#21198](go-gitea/gitea#21198)) - Enable fluid page layout on medium size viewports ([#21178](go-gitea/gitea#21178)) - File header tweaks ([#21175](go-gitea/gitea#21175)) - Added missing headers on user packages page ([#21172](go-gitea/gitea#21172)) - Display image digest for container packages ([#21170](go-gitea/gitea#21170)) - Skip dirty check for team forms ([#21154](go-gitea/gitea#21154)) - Keep path when creating a new branch ([#21153](https://github.com/go-gitea/gitea/issues/21153)) - Remove fomantic image module ([#21145](https://github.com/go-gitea/gitea/issues/21145)) - Make labels clickable in the comments section. ([#21137](https://github.com/go-gitea/gitea/issues/21137)) - Sort branches and tags by date descending ([#21136](https://github.com/go-gitea/gitea/issues/21136)) - Better repo API unit checks ([#21130](https://github.com/go-gitea/gitea/issues/21130)) - Improve commit status icons ([#21124](https://github.com/go-gitea/gitea/issues/21124)) - Limit length of repo description and repo url input fields ([#21119](https://github.com/go-gitea/gitea/issues/21119)) - Show .editorconfig errors in frontend ([#21088](https://github.com/go-gitea/gitea/issues/21088)) - Allow poster to choose reviewers ([#21084](https://github.com/go-gitea/gitea/issues/21084)) - Remove black labels and CSS cleanup ([#21003](https://github.com/go-gitea/gitea/issues/21003)) - Make e-mail sanity check more precise ([#20991](https://github.com/go-gitea/gitea/issues/20991)) - Use native inputs in whitespace dropdown ([#20980](https://github.com/go-gitea/gitea/issues/20980)) - Enhance package date display ([#20928](https://github.com/go-gitea/gitea/issues/20928)) - Display total blob size of a package version ([#20927](https://github.com/go-gitea/gitea/issues/20927)) - Show language name on hover ([#20923](https://github.com/go-gitea/gitea/issues/20923)) - Show instructions for all generic package files ([#20917](https://github.com/go-gitea/gitea/issues/20917)) - Refactor AssertExistsAndLoadBean to use generics ([#20797](https://github.com/go-gitea/gitea/issues/20797)) - Move the official website link at the footer of gitea ([#20777](https://github.com/go-gitea/gitea/issues/20777)) - Add support for full name in reverse proxy auth ([#20776](https://github.com/go-gitea/gitea/issues/20776)) - Remove useless JS operation for relative time tooltips ([#20756](https://github.com/go-gitea/gitea/issues/20756)) - Replace some icons with SVG ([#20741](https://github.com/go-gitea/gitea/issues/20741)) - Change commit status icons to SVG ([#20736](https://github.com/go-gitea/gitea/issues/20736)) - Improve single repo action for issue and pull requests ([#20730](https://github.com/go-gitea/gitea/issues/20730)) - Allow multiple files in generic packages ([#20661](https://github.com/go-gitea/gitea/issues/20661)) - Add option to create new issue from /issues page ([#20650](https://github.com/go-gitea/gitea/issues/20650)) - Background color of private list-items updated ([#20630](https://github.com/go-gitea/gitea/issues/20630)) - Added search input field to issue filter ([#20623](https://github.com/go-gitea/gitea/issues/20623)) - Increase default item listing size `ISSUE_PAGING_NUM` to 20 ([#20547](https://github.com/go-gitea/gitea/issues/20547)) - Modify milestone search keywords to be case insensitive again ([#20513](https://github.com/go-gitea/gitea/issues/20513)) - Show hint to link package to repo when viewing empty repo package list ([#20504](https://github.com/go-gitea/gitea/issues/20504)) - Add Tar ZSTD support ([#20493](https://github.com/go-gitea/gitea/issues/20493)) - Make code review checkboxes clickable ([#20481](https://github.com/go-gitea/gitea/issues/20481)) - Add "X-Gitea-Object-Type" header for GET `/raw/` & `/media/` API ([#20438](https://github.com/go-gitea/gitea/issues/20438)) - Display project in issue list ([#20434](https://github.com/go-gitea/gitea/issues/20434)) - Prepend commit message to template content when opening a new PR ([#20429](https://github.com/go-gitea/gitea/issues/20429)) - Replace fomantic popup module with tippy.js ([#20428](https://github.com/go-gitea/gitea/issues/20428)) - Allow to specify colors for text in markup ([#20363](https://github.com/go-gitea/gitea/issues/20363)) - Allow access to the Public Organization Member lists with minimal permissions ([#20330](https://github.com/go-gitea/gitea/issues/20330)) - Use default values when provided values are empty ([#20318](https://github.com/go-gitea/gitea/issues/20318)) - Vertical align navbar avatar at middle ([#20302](https://github.com/go-gitea/gitea/issues/20302)) - Delete cancel button in repo creation page ([#21381](https://github.com/go-gitea/gitea/issues/21381)) - Include login_name in adminCreateUser response ([#20283](https://github.com/go-gitea/gitea/issues/20283)) - fix: icon margin in user/settings/repos ([#20281](https://github.com/go-gitea/gitea/issues/20281)) - Remove blue text on migrate page ([#20273](https://github.com/go-gitea/gitea/issues/20273)) - Modify milestone search keywords to be case insensitive ([#20266](https://github.com/go-gitea/gitea/issues/20266)) - Move some files into models' sub packages ([#20262](https://github.com/go-gitea/gitea/issues/20262)) - Add tooltip to repo icons in explore page ([#20241](https://github.com/go-gitea/gitea/issues/20241)) - Remove deprecated licenses ([#20222](https://github.com/go-gitea/gitea/issues/20222)) - Webhook for Wiki changes ([#20219](https://github.com/go-gitea/gitea/issues/20219)) - Share HTML template renderers and create a watcher framework ([#20218](https://github.com/go-gitea/gitea/issues/20218)) - Allow enable LDAP source and disable user sync via CLI ([#20206](https://github.com/go-gitea/gitea/issues/20206)) - Adds a checkbox to select all issues/PRs ([#20177](https://github.com/go-gitea/gitea/issues/20177)) - Refactor `i18n` to `locale` ([#20153](go-gitea/gitea#20153)) - Disable status checks in template if none found ([#20088](https://github.com/go-gitea/gitea/issues/20088)) - Allow manager logging to set SQL ([#20064](https://github.com/go-gitea/gitea/issues/20064)) - Add order by for assignee no sort issue ([#20053](https://github.com/go-gitea/gitea/issues/20053)) - Take a stab at porting existing components to Vue3 ([#20044](https://github.com/go-gitea/gitea/issues/20044)) - Add doctor command to write commit-graphs ([#20007](https://github.com/go-gitea/gitea/issues/20007)) - Add support for authentication based on reverse proxy email ([#19949](https://github.com/go-gitea/gitea/issues/19949)) - Enable spellcheck for EasyMDE, use contenteditable mode ([#19776](https://github.com/go-gitea/gitea/issues/19776)) - Allow specifying SECRET_KEY_URI, similar to INTERNAL_TOKEN_URI ([#19663](https://github.com/go-gitea/gitea/issues/19663)) - Rework mailer settings ([#18982](go-gitea/gitea#18982)) - Add option to purge users ([#18064](https://github.com/go-gitea/gitea/issues/18064)) - Add author search input ([#21246](https://github.com/go-gitea/gitea/issues/21246)) - Make rss/atom identifier globally unique ([#21550](https://github.com/go-gitea/gitea/issues/21550)) - BUGFIXES - Auth interface return error when verify failure ([#22119](https://github.com/go-gitea/gitea/issues/22119)) ([#22259](https://github.com/go-gitea/gitea/issues/22259)) - Use complete SHA to create and query commit status ([#22244](https://github.com/go-gitea/gitea/issues/22244)) ([#22257](https://github.com/go-gitea/gitea/issues/22257)) - Update bleve and zapx to fix unaligned atomic ([#22031](https://github.com/go-gitea/gitea/issues/22031)) ([#22218](https://github.com/go-gitea/gitea/issues/22218)) - Prevent panic in doctor command when running default checks ([#21791](https://github.com/go-gitea/gitea/issues/21791)) ([#21807](https://github.com/go-gitea/gitea/issues/21807)) - Load GitRepo in API before deleting issue ([#21720](https://github.com/go-gitea/gitea/issues/21720)) ([#21796](https://github.com/go-gitea/gitea/issues/21796)) - Ignore line anchor links with leading zeroes ([#21728](go-gitea/gitea#21728)) ([#21776](go-gitea/gitea#21776)) - Set last login when activating account ([#21731](https://github.com/go-gitea/gitea/issues/21731)) ([#21755](https://github.com/go-gitea/gitea/issues/21755)) - Fix UI language switching bug ([#21597](https://github.com/go-gitea/gitea/issues/21597)) ([#21749](https://github.com/go-gitea/gitea/issues/21749)) - Quick fixes monaco-editor error: "vs.editor.nullLanguage" ([#21734](go-gitea/gitea#21734)) ([#21738](go-gitea/gitea#21738)) - Allow local package identifiers for PyPI packages ([#21690](https://github.com/go-gitea/gitea/issues/21690)) ([#21727](https://github.com/go-gitea/gitea/issues/21727)) - Deal with markdown template without metadata ([#21639](https://github.com/go-gitea/gitea/issues/21639)) ([#21654](https://github.com/go-gitea/gitea/issues/21654)) - Fix opaque background on mermaid diagrams ([#21642](https://github.com/go-gitea/gitea/issues/21642)) ([#21652](https://github.com/go-gitea/gitea/issues/21652)) - Fix repository adoption on Windows ([#21646](https://github.com/go-gitea/gitea/issues/21646)) ([#21650](https://github.com/go-gitea/gitea/issues/21650)) - Sync git hooks when config file path changed ([#21619](https://github.com/go-gitea/gitea/issues/21619)) ([#21626](https://github.com/go-gitea/gitea/issues/21626)) - Fix 500 on PR files API ([#21602](https://github.com/go-gitea/gitea/issues/21602)) ([#21607](https://github.com/go-gitea/gitea/issues/21607)) - Fix `Timestamp.IsZero` ([#21593](https://github.com/go-gitea/gitea/issues/21593)) ([#21603](https://github.com/go-gitea/gitea/issues/21603)) - Fix viewing user subscriptions ([#21482](https://github.com/go-gitea/gitea/issues/21482)) - Fix mermaid-related bugs ([#21431](https://github.com/go-gitea/gitea/issues/21431)) - Fix branch dropdown shifting on page load ([#21428](https://github.com/go-gitea/gitea/issues/21428)) - Fix default theme-auto selector when nologin ([#21346](https://github.com/go-gitea/gitea/issues/21346)) - Fix and improve incorrect error messages ([#21342](https://github.com/go-gitea/gitea/issues/21342)) - Fix formatted link for PR review notifications to matrix ([#21319](https://github.com/go-gitea/gitea/issues/21319)) - Center-aligning content of WebAuthN page ([#21127](https://github.com/go-gitea/gitea/issues/21127)) - Remove follow from commits by file ([#20765](https://github.com/go-gitea/gitea/issues/20765)) - Fix commit status popup ([#20737](https://github.com/go-gitea/gitea/issues/20737)) - Fix init mail render logic ([#20704](https://github.com/go-gitea/gitea/issues/20704)) - Use correct page size for link header pagination ([#20546](https://github.com/go-gitea/gitea/issues/20546)) - Preserve unix socket file ([#20499](https://github.com/go-gitea/gitea/issues/20499)) - Use tippy.js for context popup ([#20393](https://github.com/go-gitea/gitea/issues/20393)) - Add missing parameter for error in log message ([#20144](https://github.com/go-gitea/gitea/issues/20144)) - Do not allow organisation owners add themselves as collaborator ([#20043](https://github.com/go-gitea/gitea/issues/20043)) - Rework file highlight rendering and fix yaml copy-paste ([#19967](https://github.com/go-gitea/gitea/issues/19967)) - Improve code diff highlight, fix incorrect rendered diff result ([#19958](https://github.com/go-gitea/gitea/issues/19958)) - TESTING - Improve OAuth integration tests ([#21390](https://github.com/go-gitea/gitea/issues/21390)) - Add playwright tests ([#20123](https://github.com/go-gitea/gitea/issues/20123)) - BUILD - Switch to building with go1.19 ([#20695](https://github.com/go-gitea/gitea/issues/20695)) - Update JS dependencies, adjust eslint ([#20659](https://github.com/go-gitea/gitea/issues/20659)) - Add more linters to improve code readability ([#19989](https://github.com/go-gitea/gitea/issues/19989)) ### [`v1.17.4`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1174-httpsgithubcomgo-giteagiteareleasestagv1174---2022-12-21) [Compare Source](go-gitea/gitea@v1.17.3...v1.17.4) - SECURITY - Do not allow Ghost access to limited visible user/org ([#21849](https://github.com/go-gitea/gitea/issues/21849)) ([#21875](https://github.com/go-gitea/gitea/issues/21875)) - Fix package access for admins and inactive users ([#21580](https://github.com/go-gitea/gitea/issues/21580)) ([#21592](https://github.com/go-gitea/gitea/issues/21592)) - ENHANCEMENTS - Fix button in branch list, avoid unexpected page jump before restore branch actually done ([#21562](go-gitea/gitea#21562)) ([#21927](https://github.com/go-gitea/gitea/issues/21927)) - Fix vertical align of committer avatar rendered by email address ([#21884](go-gitea/gitea#21884)) ([#21919](https://github.com/go-gitea/gitea/issues/21919)) - Fix setting HTTP headers after write ([#21833](go-gitea/gitea#21833)) ([#21874](https://github.com/go-gitea/gitea/issues/21874)) - Ignore line anchor links with leading zeroes ([#21728](go-gitea/gitea#21728)) ([#21777](https://github.com/go-gitea/gitea/issues/21777)) - Enable Monaco automaticLayout ([#21516](https://github.com/go-gitea/gitea/issues/21516)) - BUGFIXES - Do not list active repositories as unadopted ([#22034](https://github.com/go-gitea/gitea/issues/22034)) ([#22167](https://github.com/go-gitea/gitea/issues/22167)) - Correctly handle moved files in apply patch ([#22118](https://github.com/go-gitea/gitea/issues/22118)) ([#22136](https://github.com/go-gitea/gitea/issues/22136)) - Fix condition for is_internal ([#22095](https://github.com/go-gitea/gitea/issues/22095)) ([#22131](https://github.com/go-gitea/gitea/issues/22131)) - Fix permission check on issue/pull lock ([#22114](https://github.com/go-gitea/gitea/issues/22114)) - Fix sorting admin user list by last login ([#22081](https://github.com/go-gitea/gitea/issues/22081)) ([#22106](https://github.com/go-gitea/gitea/issues/22106)) - Workaround for container registry push/pull errors ([#21862](https://github.com/go-gitea/gitea/issues/21862)) ([#22069](https://github.com/go-gitea/gitea/issues/22069)) - Fix issue/PR numbers ([#22037](https://github.com/go-gitea/gitea/issues/22037)) ([#22045](https://github.com/go-gitea/gitea/issues/22045)) - Handle empty author names ([#21902](https://github.com/go-gitea/gitea/issues/21902)) ([#22028](https://github.com/go-gitea/gitea/issues/22028)) - Fix ListBranches to handle empty case ([#21921](https://github.com/go-gitea/gitea/issues/21921)) ([#22025](https://github.com/go-gitea/gitea/issues/22025)) - Fix enabling partial clones on 1.17 ([#21809](https://github.com/go-gitea/gitea/issues/21809)) - Prevent panic in doctor command when running default checks ([#21791](https://github.com/go-gitea/gitea/issues/21791)) ([#21808](https://github.com/go-gitea/gitea/issues/21808)) - Upgrade golang.org/x/crypto ([#21792](https://github.com/go-gitea/gitea/issues/21792)) ([#21794](https://github.com/go-gitea/gitea/issues/21794)) - Init git module before database migration ([#21764](https://github.com/go-gitea/gitea/issues/21764)) ([#21766](https://github.com/go-gitea/gitea/issues/21766)) - Set last login when activating account ([#21731](https://github.com/go-gitea/gitea/issues/21731)) ([#21754](https://github.com/go-gitea/gitea/issues/21754)) - Add HEAD fix to gitea doctor ([#21352](https://github.com/go-gitea/gitea/issues/21352)) ([#21751](https://github.com/go-gitea/gitea/issues/21751)) - Fix UI language switching bug ([#21597](https://github.com/go-gitea/gitea/issues/21597)) ([#21748](https://github.com/go-gitea/gitea/issues/21748)) - Remove semver compatible flag and change pypi to an array of test cases ([#21708](https://github.com/go-gitea/gitea/issues/21708)) ([#21729](https://github.com/go-gitea/gitea/issues/21729)) - Allow local package identifiers for PyPI packages ([#21690](https://github.com/go-gitea/gitea/issues/21690)) ([#21726](https://github.com/go-gitea/gitea/issues/21726)) - Fix repository adoption on Windows ([#21646](https://github.com/go-gitea/gitea/issues/21646)) ([#21651](https://github.com/go-gitea/gitea/issues/21651)) - Sync git hooks when config file path changed ([#21619](https://github.com/go-gitea/gitea/issues/21619)) ([#21625](https://github.com/go-gitea/gitea/issues/21625)) - Added check for disabled Packages ([#21540](https://github.com/go-gitea/gitea/issues/21540)) ([#21614](https://github.com/go-gitea/gitea/issues/21614)) - Fix `Timestamp.IsZero` ([#21593](https://github.com/go-gitea/gitea/issues/21593)) ([#21604](https://github.com/go-gitea/gitea/issues/21604)) - Fix issues count bug ([#21600](https://github.com/go-gitea/gitea/issues/21600)) - Support binary deploy in npm packages ([#21589](https://github.com/go-gitea/gitea/issues/21589)) - Update milestone counters when issue is deleted ([#21459](https://github.com/go-gitea/gitea/issues/21459)) ([#21586](https://github.com/go-gitea/gitea/issues/21586)) - SessionUser protection against nil pointer dereference ([#21581](https://github.com/go-gitea/gitea/issues/21581)) - Case-insensitive NuGet symbol file GUID ([#21409](https://github.com/go-gitea/gitea/issues/21409)) ([#21575](https://github.com/go-gitea/gitea/issues/21575)) - Suppress `ExternalLoginUserNotExist` error ([#21504](https://github.com/go-gitea/gitea/issues/21504)) ([#21572](https://github.com/go-gitea/gitea/issues/21572)) - Prevent Authorization header for presigned LFS urls ([#21531](https://github.com/go-gitea/gitea/issues/21531)) ([#21569](https://github.com/go-gitea/gitea/issues/21569)) - Update binding to fix bugs ([#21560](https://github.com/go-gitea/gitea/issues/21560)) - Fix generating compare link ([#21519](https://github.com/go-gitea/gitea/issues/21519)) ([#21530](https://github.com/go-gitea/gitea/issues/21530)) - Ignore error when retrieving changed PR review files ([#21487](https://github.com/go-gitea/gitea/issues/21487)) ([#21524](https://github.com/go-gitea/gitea/issues/21524)) - Fix incorrect notification commit url ([#21479](https://github.com/go-gitea/gitea/issues/21479)) ([#21483](https://github.com/go-gitea/gitea/issues/21483)) - Display total commit count in hook message ([#21400](https://github.com/go-gitea/gitea/issues/21400)) ([#21481](https://github.com/go-gitea/gitea/issues/21481)) - Enforce grouped NuGet search results ([#21442](https://github.com/go-gitea/gitea/issues/21442)) ([#21480](https://github.com/go-gitea/gitea/issues/21480)) - Return 404 when user is not found on avatar ([#21476](https://github.com/go-gitea/gitea/issues/21476)) ([#21477](https://github.com/go-gitea/gitea/issues/21477)) - Normalize NuGet package version on upload ([#22186](https://github.com/go-gitea/gitea/issues/22186)) ([#22201](https://github.com/go-gitea/gitea/issues/22201)) - MISC - Check for zero time instant in TimeStamp.IsZero() ([#22171](https://github.com/go-gitea/gitea/issues/22171)) ([#22173](https://github.com/go-gitea/gitea/issues/22173)) - Fix warn in database structs sync ([#22111](https://github.com/go-gitea/gitea/issues/22111)) - Allow for resolution of NPM registry paths that match upstream ([#21568](https://github.com/go-gitea/gitea/issues/21568)) ([#21723](https://github.com/go-gitea/gitea/issues/21723)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Michael Wittig <michael.wittig@posteo.de> Reviewed-on: https://gitea.sh4ke.rocks/sh4ke/k8s-projects/pulls/84

zeripath added type/bug backport/v1.17 outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Dec 13, 2022

zeripath added this to the 1.19.0 milestone Dec 13, 2022

lunny approved these changes Dec 13, 2022

View reviewed changes

GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 13, 2022

Merge branch 'main' into fix-22083-detect-no-such-file

ffe611f

techknowlogick approved these changes Dec 13, 2022

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2022

techknowlogick requested changes Dec 13, 2022

View reviewed changes

zeripath added 2 commits December 13, 2022 22:33

Add trace logging for stderr in check patch

5f2d39c

Signed-off-by: Andrew Thornton <art27@cantab.net>

And handle "does not exist in index"

f686bd4

Signed-off-by: Andrew Thornton <art27@cantab.net>

techknowlogick approved these changes Dec 14, 2022

View reviewed changes

Merge branch 'main' into fix-22083-detect-no-such-file

27aeb34

techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 14, 2022

techknowlogick and others added 2 commits December 14, 2022 01:15

Merge branch 'main' into fix-22083-detect-no-such-file

c9ee0a5

Merge branch 'main' into fix-22083-detect-no-such-file

2f60518

lunny merged commit cdc4345 into go-gitea:main Dec 14, 2022

lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 14, 2022

zeripath mentioned this pull request Dec 14, 2022

Correctly handle moved files in apply patch (#22118) #22135

Merged

zeripath mentioned this pull request Dec 14, 2022

Correctly handle moved files in apply patch (#22118) #22136

Merged

zeripath added the backport/done All backports for this PR have been created label Dec 14, 2022

zeripath deleted the fix-22083-detect-no-such-file branch December 15, 2022 17:35

AbdulrhmnGhanem mentioned this pull request Dec 30, 2022

Fork updates from go-gitea/gitea main #58 kitspace/gitea#59

Merged

go-gitea locked and limited conversation to collaborators May 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Correctly handle moved files in apply patch #22118

Correctly handle moved files in apply patch #22118

Uh oh!

zeripath commented Dec 13, 2022

jtran commented Dec 13, 2022

techknowlogick left a comment

zeripath commented Dec 13, 2022

jtran commented Dec 13, 2022

jtran commented Dec 13, 2022 •

edited

Loading

zeripath commented Dec 13, 2022

lunny commented Dec 14, 2022

Labels

5 participants

Uh oh!

Correctly handle moved files in apply patch #22118

Correctly handle moved files in apply patch #22118

Uh oh!

Conversation

zeripath commented Dec 13, 2022

jtran commented Dec 13, 2022

techknowlogick left a comment

Choose a reason for hiding this comment

zeripath commented Dec 13, 2022

jtran commented Dec 13, 2022

jtran commented Dec 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

zeripath commented Dec 13, 2022

lunny commented Dec 14, 2022

Labels

5 participants

jtran commented Dec 13, 2022 •

edited

Loading