Skip to content

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented May 5, 2025

@dhomeier dhomeier added testing Unit tests no-changelog-entry-needed Skip in Changelog generation labels May 6, 2025
updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.4 → v0.11.12](astral-sh/ruff-pre-commit@v0.11.4...v0.11.12)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from beea3cc to de68a70 Compare June 2, 2025 20:31
@dhomeier
Copy link
Contributor

dhomeier commented Jun 4, 2025

Similar pytest failure as in glue-viz/glue#2542, but here it's not quite as clear what to assert

figure = image.axes.figure
image.close()
return figure

to – check for figure size, or just its type?

@astrofrog
Copy link
Member

astrofrog commented Jun 5, 2025

Well this is an image test so returning the figure is the right thing to do

@dhomeier
Copy link
Contributor

dhomeier commented Jun 5, 2025

The function is not called from anywhere externally using the return value, is it?
But anyway seems pytest did not quite know what they were doing there pytest-dev/pytest#13477.
I actually cannot reproduce this locally, neither the warning nor the error with 8.4 so not sure if adding this to filterwarnings will still help at this point, or if we should just pin to pytest<8.4 until it's (hopefully) fixed.
Update: should be resolved with the next 8.4 release in pytest-dev/pytest#13495

Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing with pytest 8.4.1, should perhaps filter the warning though.
New failure in test_aspect_resize (pytest not raising with PyQt5, on Linux only) is obviously unrelated, better addressed in a new PR, so this should be good to merge.

@dhomeier dhomeier merged commit 1cb77d8 into main Jun 24, 2025
48 of 91 checks passed
@dhomeier dhomeier deleted the pre-commit-ci-update-config branch June 24, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed Skip in Changelog generation testing Unit tests

3 participants