Skip to content

Added fixes for new flexible heredoc from php7.3 #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 26, 2020
Merged

Added fixes for new flexible heredoc from php7.3 #506

merged 6 commits into from
Mar 26, 2020

Conversation

jodysimpson
Copy link
Contributor

This pull provides heredoc fixes for the following situations which are all valid in php7.3:

stringManipulator(<<<END  a  b  c END);
$values = [<<<END a b c END, 'd e f'];
$values = [<<<END a b c END , 'd e f'];
$values = [<<<END  a   b   c   END];
@coveralls
Copy link

coveralls commented Mar 7, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 96.182% when pulling 0ee6acc on jodysimpson:FIX-flexible-heredoc into 2db6127 on glayzzle:master.
@ichiriac ichiriac self-requested a review March 10, 2020 22:20
@ichiriac
Copy link
Member

Hi @jodysimpson, many thanks for the PR - I'll review your code this week-end 👍
ichiriac
ichiriac reviewed Mar 13, 2020
View reviewed changes
ichiriac
ichiriac reviewed Mar 13, 2020
View reviewed changes
src/lexer/strings.js
// go go go
this.heredoc_label.label = yylabel;
this.heredoc_label.length = yylabel.length;
this.heredoc_label.finished = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
ichiriac
ichiriac requested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some time in order to prepare token tests. @jodysimpson could you please make some minor changes on valid_endings and test with windows line endings \r\n
@czosel czosel mentioned this pull request Mar 15, 2020
Closed
@ichiriac ichiriac merged commit 66a3c38 into glayzzle:master Mar 26, 2020
@ichiriac
Copy link
Member

@jodysimpson - your PR is now merged and will be released soon. Many thanks for your contribution 👍 ❤️
@ichiriac ichiriac mentioned this pull request Mar 26, 2020
Closed
@Spice-King Spice-King mentioned this pull request Jun 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@jodysimpson @coveralls @ichiriac