Skip to content

Add global config file support for SharedOptions #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
remique wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add global config file support for SharedOptions #2207

remique wants to merge 4 commits into from

Conversation

@remique
Copy link
Contributor

@remique remique commented Apr 28, 2024

This Pull Request fixes/closes #2140.

It changes the following:

  • If gitui fails to find a local config file, it falls back to global options under $GITUI_HOME/gitui.ron

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Also:

  1. We should probably document this somewhere? If a person sets a global config and then sees that it does not change a thing in his gitui (due to the local config), they might be confused.
  2. I have renamed gitui file to gitui.ron so that both global and local configs match. I hope that's okay.
@remique remique marked this pull request as ready for review May 4, 2024 09:47
@remique
Copy link
Contributor Author

remique commented May 4, 2024

Oh, I was surprised by builds not passing but I see that clippy::empty_docs has been added in 1.78.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@remique