Skip to content

Conversation

@easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 5, 2022

Description

Speed-up first commit in a workspace by pre-installing hooks. Without this, they are first installed when a commit is issued (and corresponding git hook triggered).

Relevant docs: https://pre-commit.com/#pre-commit-install-hooks

Related Issue(s)

Fixes #

How to test

  1. Create a branch based on this
  2. Modify a file
  3. Commit the file, should not block on installing the hooks

Release Notes

NONE 

Documentation

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@easyCZ easyCZ requested review from ArthurSens, geropl and jeanp413 April 5, 2022 14:24
Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🚀

Thanks for reacting on this so quickly :)

@roboquat roboquat merged commit 020a4b9 into main Apr 5, 2022
@roboquat roboquat deleted the mp/pre-commit-hooks-before branch April 5, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment