Skip to content

Add env var name/value length validation #8248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roboquat merged 2 commits into from
May 6, 2022
Merged

Add env var name/value length validation #8248

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e41a76d
Add env var name/value length validation
randomir Feb 4, 2022
72ad89c
Reduce env var value UI limit to 32k-1 for consistency
randomir Feb 16, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add env var name/value length validation 
Also, decrease maxlen for value from ~64k*3/4 to a nice round 32k.
  • Loading branch information
@randomir
randomir committed May 4, 2022
commit e41a76da99f8ff1e667986a1ae54139218cb7346
6 changes: 6 additions & 0 deletions components/gitpod-protocol/src/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,18 @@ export namespace UserEnvVar {
if (name.trim() === "") {
return "Name must not be empty.";
}
if (name.length > 255) {
return 'Name too long. Maximum name length is 255 characters.';
}
if (!/^[a-zA-Z_]+[a-zA-Z0-9_]*$/.test(name)) {
return "Name must match /^[a-zA-Z_]+[a-zA-Z0-9_]*$/.";
}
if (variable.value.trim() === "") {
return "Value must not be empty.";
}
if (variable.value.length > 32768) {
return 'Value too long. Maximum value length is 32768 characters.';
}
if (pattern.trim() === "") {
return "Scope must not be empty.";
}
Expand Down