Skip to content

[image-builder] Removing delays and getting the image-builder to return the correct build state #7035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roboquat merged 1 commit into from
Dec 2, 2021
Merged

[image-builder] Removing delays and getting the image-builder to return the correct build state #7035

roboquat merged 1 commit into from
Dec 2, 2021

Conversation

@iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Dec 2, 2021 •
edited
Loading

Description

Removing not required delays after #6963 is merged
Let the image-builder to return the correct build state after #6963 is merged

This is a revert for ee19cd8

in this PR preview env
image

in prod
image

Related Issue(s)

Fixes #

How to test

https://pd-image-builder-revert.staging.gitpod-dev.com/#https://github.com/iQQBot/test.test

Release Notes

NONE

Documentation
@roboquat roboquat added release-note-none team: workspace Issue belongs to the Workspace team labels Dec 2, 2021
@iQQBot iQQBot requested a review from csweichel December 2, 2021 16:15
@csweichel
Copy link
Contributor

csweichel commented Dec 2, 2021

/lgtm
@roboquat roboquat added the lgtm label Dec 2, 2021
@csweichel
Copy link
Contributor

csweichel commented Dec 2, 2021

/lgtm cancel
@roboquat roboquat removed the lgtm label Dec 2, 2021
@csweichel
Copy link
Contributor

csweichel commented Dec 2, 2021

Did not catch that in time.

The delay's purpose is to give the log listener in image-builder enough time to connect if the build fails too quickly.
I reckon we should keep the delay, but change the return to Fatal.
@iQQBot
Copy link
Contributor Author

iQQBot commented Dec 2, 2021

OK
@iQQBot iQQBot force-pushed the pd/image-builder-revert branch from 43a5a8b to aaffa2a Compare December 2, 2021 16:25
@iQQBot
Copy link
Contributor Author

iQQBot commented Dec 2, 2021

@csweichel Already changed
@iQQBot
Copy link
Contributor Author

iQQBot commented Dec 2, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pd-image-builder-revert.2
@csweichel
Copy link
Contributor

csweichel commented Dec 2, 2021

/lgtm
@roboquat roboquat added the lgtm label Dec 2, 2021
@roboquat
Copy link
Contributor

roboquat commented Dec 2, 2021

LGTM label has been added.

DetailsGit tree hash: eb6fe3cb5bacaf8529bf352a976b0776b2f6ea5a
@csweichel
Copy link
Contributor

csweichel commented Dec 2, 2021

/approve no-issue
@roboquat
Copy link
Contributor

roboquat commented Dec 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@roboquat roboquat merged commit 982dc38 into main Dec 2, 2021
@roboquat roboquat deleted the pd/image-builder-revert branch December 2, 2021 19:52
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team

4 participants

@iQQBot @csweichel @roboquat