[supervisor] fixes not recycle zombie processes

[iQQBot]

Description

[supervisor] fixes not recycle zombie processes

Related Issue(s)

Fixes #6976

How to test

Release Notes

NONE 

Documentation

[iQQBot]

This is rare and usually exceeds the maximum threshold of the notifications channel to be reproduced

[codecov]

Codecov Report

Merging #6977 (986477d) into main (eee9847) will increase coverage by 18.07%.
The diff coverage is 0.00%.

❗ Current head 986477d differs from pull request most recent head 53722ba. Consider uploading reports for the commit 53722ba to get more accurate results

@@ Coverage Diff @@ ## main #6977 +/- ## =========================================== + Coverage 19.04% 37.12% +18.07%  =========================================== Files 2 19 +17 Lines 168 4577 +4409 =========================================== + Hits 32 1699 +1667  - Misses 134 2745 +2611  - Partials 2 133 +131 

Flag	Coverage Δ
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
components-supervisor-app	37.12% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/supervisor/pkg/supervisor/supervisor.go	6.06% <0.00%> (ø)
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/supervisor/pkg/supervisor/ssh.go	0.00% <0.00%> (ø)
components/supervisor/pkg/ports/exposed-ports.go	0.00% <0.00%> (ø)
components/supervisor/pkg/ports/ports-config.go	80.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go	23.82% <0.00%> (ø)
components/supervisor/pkg/config/gitpod-config.go	79.46% <0.00%> (ø)
components/supervisor/pkg/terminal/service.go	32.38% <0.00%> (ø)
components/supervisor/pkg/dropwriter/dropwriter.go	73.46% <0.00%> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee9847...53722ba. Read the comment docs.

[csweichel]

Great find! Well done indeed.

Other than a small comment nit, this lgtm. Feel free to unhold merge as is, or change the comment :)

/hold
/lgtm

[roboquat]

LGTM label has been added.

Details

Git tree hash: e4c87b45a449ee5edb81074776c50e89177e1860

[iQQBot]

@csweichel can't find comment...

[akosyakov]

/approve

[csweichel]

/lgtm

[roboquat]

LGTM label has been added.

Details

Git tree hash: 947c43f95488352d625def94344ee3cefcf64f98

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, csweichel

Associated issue: #6976

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• components/supervisor/OWNERS [akosyakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[csweichel]

/hold cancel