Skip to content

Conversation

@mrsimonemms
Copy link
Contributor

Description

Applied the node affinities as specified in #6842. Have also given Jobs the same affinities as their associated Deployments

The only question is what, if any, affinities to put on the in-cluster Docker registry and the Jaeger operators

Related Issue(s)

Fixes #6842

How to test

Deploy a self-hosted instance

Release Notes

Apply node affinities to components 

Documentation

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team size/L labels Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #6862 (df7df11) into main (85714ab) will decrease coverage by 12.83%.
The diff coverage is 0.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## main #6862 +/- ## ========================================== - Coverage 19.04% 6.21% -12.84%  ========================================== Files 2 12 +10 Lines 168 1078 +910 ========================================== + Hits 32 67 +35  - Misses 134 1010 +876  + Partials 2 1 -1 
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 6.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 29.71% <0.00%> (ø)
installer/pkg/common/display.go 0.00% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85714ab...df7df11. Read the comment docs.

@mrsimonemms mrsimonemms force-pushed the sje/installer-affinities branch from 5960402 to df7df11 Compare November 24, 2021 15:53
@mrsimonemms
Copy link
Contributor Author

@csweichel made the change to the Helm package (good idea).

What do you want to do about the Docker Registry and Jaeger Operators - both Helm charts accept nodeAffinity, but they're not defined in the original issue

@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 8d33b17ac76679eab8319a2f87a3fff1fac65b86

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #6842

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit c1deb14 into main Nov 24, 2021
@roboquat roboquat deleted the sje/installer-affinities branch November 24, 2021 16:07
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/L team: workspace Issue belongs to the Workspace team

4 participants