[dev] slim down dev image #6797
Conversation
roboquat added release-note-none do-not-merge/work-in-progress team: IDE team: workspace 
Codecov Report
@@ Coverage Diff @@ ## main #6797 +/- ## =========================================== + Coverage 19.55% 37.03% +17.47% =========================================== Files 22 19 -3 Lines 1810 4577 +2767 =========================================== + Hits 354 1695 +1341 - Misses 1413 2748 +1335 - Partials 43 134 +91
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
|
geropl force-pushed the gpl/6665-slim-image branch from bea459e to afcc866 Compare |
|
jankeromnes left a comment
jankeromnes left a comment There was a problem hiding this comment.
New dev image seems to work, and newer is always better! ❤️
Muchas gracias 🚢
| LGTM label has been added. DetailsGit tree hash: 49106327b25c2d476e78d4da342a7d98190fdf14 |
| /approve |
| # Scratchpad | ||
| | ||
| ``` | ||
| leeway build components/agent-smith:falco-bpf-probe --serve 0.0.0.0:8081 |
There was a problem hiding this comment.
FATA[0001] package "components/agent-smith:falco-bpf-probe" does not exist
did it miss something?
There was a problem hiding this comment.
agent-smith is no longer BPF based. We should remove this from the readme
There was a problem hiding this comment.
Ouch, this came back during a revert+rebase somehow. Will remove in follow-up.
| | ||
| sudo qemu-system-x86_64 -kernel "${vmlinuz}" \ | ||
| -boot c -m 2049M -hda "${outdir}/bionic-server-cloudimg-amd64.qcow2" \ | ||
| -boot c -m 2049M -hda "${outdir}/bionic-server-cloudimg-amd64.img" \ |
There was a problem hiding this comment.
because delete dev/image/prepare-bpf-dev-environment.sh so there is no image...
There was a problem hiding this comment.
We should remove this file entirely. No need for qemu anymore
There was a problem hiding this comment.
Ouch, this came back during a revert+rebase somehow. Will remove in follow-up.
| # Scratchpad | ||
| | ||
| ``` | ||
| leeway build components/agent-smith:falco-bpf-probe --serve 0.0.0.0:8081 |
There was a problem hiding this comment.
agent-smith is no longer BPF based. We should remove this from the readme
| | ||
| sudo qemu-system-x86_64 -kernel "${vmlinuz}" \ | ||
| -boot c -m 2049M -hda "${outdir}/bionic-server-cloudimg-amd64.qcow2" \ | ||
| -boot c -m 2049M -hda "${outdir}/bionic-server-cloudimg-amd64.img" \ |
There was a problem hiding this comment.
We should remove this file entirely. No need for qemu anymore
| ### Build QEMU VM | ||
| COPY config prepare-bpf-dev-environment.sh code workspace.mount workspace.automount /root/ | ||
| RUN /root/prepare-bpf-dev-environment.sh | ||
| RUN install-packages qemu qemu-system-x86 linux-image-$WORKSPACE_KERNEL libguestfs-tools sshpass |
There was a problem hiding this comment.
We don't need qemu anymore. Can be removed
| @geropl let's start with this PR, and trim some more fat later :) /lgtm |
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusludmann, csweichel, jankeromnes Associated issue: #6665 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
roboquat added the deployed: workspace 
Description
There seem to be further 1.3GB potential, but
divekeeps crashing, so going to merge this as-is.Related Issue(s)
Fixes #6665
How to test
Release Notes
Documentation