Skip to content

Disable focus lock on billing modal #17751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roboquat merged 1 commit into from
May 26, 2023
Merged

Disable focus lock on billing modal #17751

roboquat merged 1 commit into from
May 26, 2023

Conversation

@selfcontained
Copy link
Contributor

@selfcontained selfcontained commented May 25, 2023 •
edited by github-actions bot
Loading

Description

The billing modal potentially renders an iframe for 3ds verification. Because this is appended to the document body, we need to disable focus lock on the modal to avoid interfering with the iframe form inputs.

Related Issue(s)

Fixes WEB-413

How to test

  • Upgrade billing plan using a stripe test credit that forces 3ds verification: 4000002760003184
  • When the test verification ui appears, try and tab through the buttons. If that works, then this is successfully disabling the focus lock.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold
@selfcontained selfcontained marked this pull request as ready for review May 25, 2023 15:33
@selfcontained selfcontained requested a review from a team May 25, 2023 15:33
@selfcontained selfcontained requested a review from gtsiolis as a code owner May 25, 2023 15:33
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 25, 2023
svenefftinge
svenefftinge approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and worked
@selfcontained
Copy link
Contributor Author

selfcontained commented May 26, 2023

/unhold
@roboquat roboquat merged commit 0e11c83 into main May 26, 2023
@roboquat roboquat deleted the bmh/disable-focus-lock-billing branch May 26, 2023 01:40
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed: webapp Meta team change is running in production deployed Change is completely running in production size/S team: webapp Issue belongs to the WebApp team

4 participants

@selfcontained @svenefftinge @roboquat