Skip to content

[server] Move prebuilds out of EE #17354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roboquat merged 2 commits into from
Apr 25, 2023
Merged

[server] Move prebuilds out of EE #17354

roboquat merged 2 commits into from
Apr 25, 2023

Conversation

@easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 24, 2023 •
edited
Loading

Description

Moves prebuilds out of EE

Related Issue(s)

Fixes #

How to test

Preview

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold
@easyCZ
Copy link
Member Author

easyCZ commented Apr 25, 2023

What's the best way to test this?
@easyCZ easyCZ marked this pull request as ready for review April 25, 2023 06:22
@easyCZ easyCZ requested a review from a team April 25, 2023 06:22
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 25, 2023
@AlexTugarev
Copy link
Member

AlexTugarev commented Apr 25, 2023 •
edited
Loading

What's the best way to test this?

Create Projects for at least one of the Git hosters and check if prebuilds are triggered after pushing changes.

GH(E) works ✔️

Running on main only. I guess that's expected.

Screenshot 2023-04-25 at 09 16 23

Bitbucket works ✔️

Screenshot 2023-04-25 at 09 18 01
@easyCZ easyCZ mentioned this pull request Apr 25, 2023
Merged
14 tasks
@easyCZ
Copy link
Member Author

easyCZ commented Apr 25, 2023

Screenshot 2023-04-25 at 9 18 37

Github looks to work as well
AlexTugarev
AlexTugarev approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
@easyCZ
Copy link
Member Author

easyCZ commented Apr 25, 2023

Screenshot 2023-04-25 at 9 21 01

Gitlab also works
@easyCZ
Copy link
Member Author

easyCZ commented Apr 25, 2023

/unhold
@roboquat roboquat merged commit e777642 into main Apr 25, 2023
@roboquat roboquat deleted the mp/server-prebuilds-non-ee branch April 25, 2023 07:22
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed: webapp Meta team change is running in production deployed Change is completely running in production size/XXL team: webapp Issue belongs to the WebApp team

4 participants

@easyCZ @AlexTugarev @roboquat