Skip to content

[redis] Deploy component #16327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roboquat merged 1 commit into from
Feb 10, 2023
Merged

[redis] Deploy component #16327

roboquat merged 1 commit into from
Feb 10, 2023

Conversation

@easyCZ
Copy link
Member

@easyCZ easyCZ commented Feb 9, 2023 •
edited
Loading

Description

Deploys redis into application cluster.

  • No persistence
  • Single instance setup

Related Issue(s)

Fixes #

How to test

  1. Redis comes up in preview k8s

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh
@werft-gitpod-dev-com
Copy link

werft-gitpod-dev-com bot commented Feb 9, 2023

started the job as gitpod-build-mp-redis.1 because the annotations in the pull request description changed
(with .werft/ from main)
@roboquat roboquat added the size/L label Feb 9, 2023
@easyCZ
Copy link
Member Author

easyCZ commented Feb 9, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-mp-redis.3
(with .werft/ from main)
@werft-gitpod-dev-com
Copy link

werft-gitpod-dev-com bot commented Feb 9, 2023

started the job as gitpod-build-mp-redis.4 because the annotations in the pull request description changed
(with .werft/ from main)
@easyCZ
Copy link
Member Author

easyCZ commented Feb 9, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-redis.6
(with .werft/ from main)
@werft-gitpod-dev-com
Copy link

werft-gitpod-dev-com bot commented Feb 9, 2023

started the job as gitpod-build-mp-redis.5 because the annotations in the pull request description changed
(with .werft/ from main)
@easyCZ easyCZ marked this pull request as ready for review February 10, 2023 10:04
@easyCZ easyCZ requested review from a team February 10, 2023 10:04
@geropl
Copy link
Member

geropl commented Feb 10, 2023

Awesome! 😍

I'd love to ✔️ , but there seems to be a config error atm:

image
@easyCZ
Copy link
Member Author

easyCZ commented Feb 10, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Awesome! 😍

I'd love to ✔️ , but there seems to be a config error atm:

image

Ah, it's because I edited the deployment in preview previously, and preview doesn't overwrite/clenaup properly.
This should do it.

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-redis.9
(with .werft/ from main)
geropl
geropl approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working now 🧘 ✔️
@easyCZ
Copy link
Member Author

easyCZ commented Feb 10, 2023

Hey tide, why you no merge this?
@geropl
Copy link
Member

geropl commented Feb 10, 2023

Hey tide, why you no merge this?

@gitpod-io/engineering-security-infrastructure-and-delivery ☝️
@roboquat roboquat merged commit 460ccb0 into main Feb 10, 2023
@roboquat roboquat deleted the mp/redis branch February 10, 2023 14:34
@easyCZ
Copy link
Member Author

easyCZ commented Feb 10, 2023

Weird, that ownership was not showing up for my view
@gtsiolis gtsiolis mentioned this pull request Feb 10, 2023
Open
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed: webapp Meta team change is running in production release-note-none size/L team: security-infrastructure-and-delivery team: webapp Issue belongs to the WebApp team

5 participants

@easyCZ @geropl @vulkoingim @roboquat