[server] Extend guardTeamResource with fine-grained ops #16194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
easyCZ changed the title 
easyCZ force-pushed the mp/server-team-perms-fine-grained-defs branch from ef16d23 to 7d5bdaa Compare easyCZ force-pushed the mp/server-teams-simplify branch from 08b7539 to 0dae6ed Compare easyCZ force-pushed the mp/server-team-perms-fine-grained-defs branch from 7d5bdaa to 0d12c9c Compare 
geropl approved these changes Feb 3, 2023
Member
geropl left a comment
geropl left a comment There was a problem hiding this comment.
Awesome to see this come to fruition. LGTM! ✔️
easyCZ force-pushed the mp/server-team-perms-fine-grained-defs branch from 0d12c9c to 8426ae9 Compare 
easyCZ force-pushed the mp/server-team-perms-fine-grained-defs branch from 8426ae9 to 9d62a8f Compare 
Member Author
| /unhold |
roboquat added deployed: webapp Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Adds fine-grained operations to teams, pre-cursor to actually start checking for the permissions. For now, these are logged, when the feature flag is enabled.
Related Issue(s)
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPreview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold for dependency