Skip to content

[supervisor] Use a fallback default git credentials for cloning dotfiles #16133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
axonasif wants to merge 1 commit into from
Closed

[supervisor] Use a fallback default git credentials for cloning dotfiles #16133

axonasif wants to merge 1 commit into from

Conversation

@axonasif
Copy link
Member

@axonasif axonasif commented Jan 31, 2023 •
edited
Loading

Description

Related Issue(s)

Fixes #16077 #14984

How to test

Release Notes

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh
@axonasif axonasif requested a review from a team January 31, 2023 14:42
@roboquat
Copy link
Contributor

roboquat commented Jan 31, 2023

@axonasif: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@axonasif axonasif marked this pull request as draft January 31, 2023 14:42
@werft-gitpod-dev-com
Copy link

werft-gitpod-dev-com bot commented Jan 31, 2023

started the job as gitpod-build-axonasif-dotfiles-patch.2 because the annotations in the pull request description changed
(with .werft/ from main)
@axonasif axonasif mentioned this pull request Jan 31, 2023
Closed
@axonasif
Copy link
Member Author

axonasif commented Jan 31, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-axonasif-dotfiles-patch.3
(with .werft/ from main)
akosyakov
akosyakov reviewed Jan 31, 2023
View reviewed changes
components/supervisor/pkg/supervisor/supervisor.go
username = resp.User
password = resp.Token
} else {
username = "gitpod"
Copy link
Member

@akosyakov akosyakov Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see the point. credential helper is using tokenService as well
Copy link
Member Author

@axonasif axonasif Jan 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean git would happen to use gp credential-helper while performing the clone?
@stale
Copy link

stale bot commented Feb 12, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Feb 12, 2023
@stale stale bot closed this Feb 19, 2023
@lgarron lgarron mentioned this pull request Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/release-note-label-needed do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon size/S team: IDE

4 participants

@axonasif @roboquat @akosyakov