Skip to content

Conversation

@jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Jan 28, 2023

Description

Decouple gitpod web extension

How to test

  1. Open workspace and check gitpod-web extension is activated

Release Notes

NONE 

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jp-decouple-gitpod-web.7 because the annotations in the pull request description changed
(with .werft/ from main)

@jeanp413 jeanp413 force-pushed the jp/decouple-gitpod-web branch 3 times, most recently from 2c2b61e to 6440ce8 Compare January 28, 2023 20:28
@jeanp413
Copy link
Member Author

jeanp413 commented Jan 28, 2023

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-jp-decouple-gitpod-web.14
(with .werft/ from main)

@jeanp413
Copy link
Member Author

jeanp413 commented Jan 28, 2023

/werft run

👍 started the job as gitpod-build-jp-decouple-gitpod-web.19
(with .werft/ from main)

@jeanp413 jeanp413 force-pushed the jp/decouple-gitpod-web branch 3 times, most recently from bce49c2 to 100409b Compare January 29, 2023 00:34
@jeanp413 jeanp413 marked this pull request as ready for review January 29, 2023 01:01
@jeanp413 jeanp413 requested a review from a team January 29, 2023 01:01
@jeanp413
Copy link
Member Author

/hold

@akosyakov
Copy link
Member

We need to think how we are going to rollout. Could there be some issues with race conditions, ie some start a workpace but ide service does not resolve yet new images?

@roboquat roboquat added size/M and removed size/L labels Jan 31, 2023
@mustard-mh mustard-mh force-pushed the jp/decouple-gitpod-web branch from 989102f to 9c7ddfa Compare January 31, 2023 10:09
@mustard-mh
Copy link
Contributor

mustard-mh commented Jan 31, 2023

Addressed #16073 (comment), and tested, going to add new iam in GCP

image

@mustard-mh
Copy link
Contributor

We need to think how we are going to rollout. Could there be some issues with race conditions, ie some start a workpace but ide service does not resolve yet new images?

@akosyakov We have no race conditions, as this value is constant for all commits, ide-service only will return with the previous value of the latest value, and they are both correct (we will need to write compatibility code in gitpod-io/gitpod-code repo.

@akosyakov
Copy link
Member

@mustard-mh for latest should be alright too?

@mustard-mh
Copy link
Contributor

for latest should be alright too?

@akosyakov It will be a layer of image for both latest and stable browser code, so it (gitpod-web) will always be the one we configured in constants.go

@jeanp413 jeanp413 force-pushed the jp/decouple-gitpod-web branch from 5176349 to ec51a94 Compare January 31, 2023 17:16
@jeanp413
Copy link
Member Author

There's errors in console, I remember seeing these before it's related to compilation I think, looking into it

cannot maintain connection to supervisor Error: 13 INTERNAL: Request message serialization failure: Expected argument of type supervisor.PortsStatusRequest 
@jeanp413 jeanp413 force-pushed the jp/decouple-gitpod-web branch from ec51a94 to 67cb75d Compare January 31, 2023 23:24
@roboquat roboquat added size/L and removed size/M labels Feb 1, 2023
@jeanp413
Copy link
Member Author

jeanp413 commented Feb 1, 2023

/werft run

👍 started the job as gitpod-build-jp-decouple-gitpod-web.29
(with .werft/ from main)

@jeanp413 jeanp413 force-pushed the jp/decouple-gitpod-web branch 2 times, most recently from 5b7ddfe to 3e08637 Compare February 1, 2023 06:04
@mustard-mh
Copy link
Contributor

mustard-mh commented Feb 1, 2023

There's errors in console, I remember seeing these before it's related to compilation I think, looking into it

cannot maintain connection to supervisor Error: 13 INTERNAL: Request message serialization failure: Expected argument of type supervisor.PortsStatusRequest 

Browser code in preview env is out of date, cherry-pick commits in gp-code/main may fix it (also include a fixing for loggedInUserID) cc @jeanp413

@mustard-mh mustard-mh self-requested a review February 1, 2023 06:23
@jeanp413 jeanp413 force-pushed the jp/decouple-gitpod-web branch from 3e08637 to 0481f3c Compare February 1, 2023 06:55
@jeanp413
Copy link
Member Author

jeanp413 commented Feb 1, 2023

yeah I missed the last commit in gitpod-shared fixing the bug in loggedInUserID also there was a bug in vscode compiling web release so had to rebase again 🤦

@jeanp413
Copy link
Member Author

jeanp413 commented Feb 1, 2023

To fix for the serialization error I had to refactor a little bit gitpod-shared

@jeanp413 jeanp413 force-pushed the jp/decouple-gitpod-web branch from 0481f3c to d809d01 Compare February 1, 2023 07:42
@jeanp413 jeanp413 force-pushed the jp/decouple-gitpod-web branch from d809d01 to 4ec34b3 Compare February 1, 2023 15:01
@jeanp413
Copy link
Member Author

jeanp413 commented Feb 1, 2023

/unhold

@roboquat roboquat merged commit afec88b into main Feb 1, 2023
@roboquat roboquat deleted the jp/decouple-gitpod-web branch February 1, 2023 15:15
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/L team: IDE

5 participants