[Gitpod CLI] gp rebuild improvements #15740
Merged
+91 −67
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Follow up PR of things we overlooked in the initial PR:
outcome,.won't work if the user is inside a sub-directory)docker runshould not be propagated outside of the container because it can be anything (e.g user typingexit 1) which currently gets logged as an error fromgp rebuildnilerror when there is not real errorRelated Issue(s)
Fixes #
How to test
Dockerfilewhich usedCOPYand relies on location, make sure files are copied correctly from the workspace checkout locationbashinstalled (ie.busybox)exit 1to leave the containerRelease Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh