[db] Move db models to go-db module #14770
Conversation
roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed size/M size/L and removed size/M labels 
laushinka force-pushed the lau/move-db-models-godb branch 3 times, most recently from 2d08a79 to 2c10c1b Compare 
easyCZ force-pushed the lau/move-db-models-godb branch from 2c10c1b to cd98843 Compare easyCZ force-pushed the lau/move-db-models-godb branch 2 times, most recently from 710aaeb to 4d3e646 Compare roboquat added release-note-none and removed do-not-merge/release-note-label-needed labels easyCZ force-pushed the lau/move-db-models-godb branch 4 times, most recently from 2c5a2ae to c38077e Compare 
| @mads-hartmann We'll still need the leeway change to get this PR through. Do you have a ref for the fix so we can track, please? |
easyCZ force-pushed the lau/move-db-models-godb branch from c38077e to aa94e72 Compare 
github-actions bot added team: SID team: webapp 
andrew-farries left a comment
andrew-farries left a comment There was a problem hiding this comment.
👍 Changes look mostly mechanical and I paired with @laushinka for some of this yesterday.
/hold for one small change.
| } | ||
| | ||
| // These are static connection details for tests, started by `leeway components/usage:init-testdb`. | ||
| // These are static connection details for tests, started by `leeway components/gitpod-db:init-testdb`. |
There was a problem hiding this comment.
| // These are static connection details for tests, started by `leeway components/gitpod-db:init-testdb`. | |
| // These are static connection details for tests, started by `leeway build components/gitpod-db/go:init-testdb`. |
laushinka force-pushed the lau/move-db-models-godb branch from aa94e72 to 97ab7e2 Compare 
| @laushinka @easyCZ It looks like the build is fine without the Leeway change now? |
| Thanks for the Notion doc @mads-hartmann. If ephemeral packages are something that we intend to keep using, perhaps your PR (or a followup) could add documentation about them to leeway's |
I will try to get clarity around the future of ephemeral packages with the team and Chris. If we keep them around I will for sure update the documentation 🧡 |
| @mads-hartmann I guess it's not really needed. Which raises the Q why was it needed before? The changes here are the same as in the original PR. |
| @easyCZ I think you're seeing the problem I'm describing in the PR. Looking at the logs of one of the failed jobs (job 12) you can see that it didn't need to rebuild So I think without the PR we'll see flaky builds depending on whether or not Leeway needs to build |
| @mads-hartmann Looks like you've managed to land gitpod-io/leeway#121, what changes do we need to make to this PR to use it? |
| @easyCZ I'll open a PR to bump the Leeway version everywhere now. I'll ping you as soon as it's ready, and once that's in we can merge this PR |
| @easyCZ It's in main |
easyCZ force-pushed the lau/move-db-models-godb branch from 97ab7e2 to 95fe93e Compare 
easyCZ force-pushed the lau/move-db-models-godb branch from 95fe93e to b4fc228 Compare 
| /werft run 👍 started the job as gitpod-build-lau-move-db-models-godb.27 |
| /unhold |
roboquat added the deployed: workspace 
Description
Moves DB models to
components/gitpod-db/go, so that they can be used by public-api but also usage.Changes performed in this PR:
components/usage/pkg/db into components/gitpod-db/gogoRelated Issue(s)
New attempt at #14731
Requirement for #14602
How to test
Build and unit tests
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh