Modify environment before calling Ruby

[cirosantilli]

For gitlabhq/gitlabhq#8356

[bbodenmiller]

Replaces reverted #186.

[dzaporozhets]

Does it works with SSH this time? :)

[cirosantilli]

@randx does SSH work on development? If not, how do you test it? Wasn't able to get it to work (makes sense I suppose, since my ssh deamon runs on port 22 and does not see my authorized keys under gitlab development kit).

[dzaporozhets]

@cirosantilli the only way to test it is to setup it on separate VM. Thats how I tested SSH in past

[dzaporozhets]

@cirosantilli any news on this?

[cirosantilli]

@randx sorry, I'm a bit busy. Feel free to close or try it out.

[bb-generation]

Don't know if this is still relevant, but I just tried this commit on a live 7.7 (+gitlab-shell 2.4.1) installation and it (mostly) worked.

The only problem was that there was no ./hooks/.env file initially and I got the following warnings after pushing via ssh (it still worked though):

remote: hooks/pre-receive: line 4: ./hooks/.env: No such file or directory remote: hooks/update: line 4: ./hooks/.env: No such file or directory remote: hooks/post-receive: line 4: ./hooks/.env: No such file or directory 

After I created a ./hooks/.env file (with something like export PATH=/my/new/:/corrected/path in it), everything worked. I tested pushing via ssh and editing files via the web interface (which didn't work previously for me).

[cirosantilli]

@bb-generation did you also pull https://github.com/gitlabhq/gitlabhq/pull/8356/files ? that should create the file.

[bb-generation]

@cirosantilli No, I didn't.

But now I did (after removing the gitlab-shell/hooks/.env file) and it works perfectly. No warnings and ssh+http push works fine.

[cirosantilli]

cc @randx consider reopening given bb-generation's success

[jangrewe]

+1

[devfaz]

+1

[shusain]

+1 applied the changes here too, works for me thanks for the fix