Support deleting data from the list & add support for keyboardShouldPersistTaps prop #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I dropped a comment on PR #139, but it seems this bug was introduced when that was merged. |
andrewbeckman changed the title added 2 commits April 29, 2019 13:30
VietQuoc reviewed Oct 6, 2020
| }); | ||
| }); | ||
| | ||
| if (Object.keys(nextData).length > Object.keys(data).length) { |
There was a problem hiding this comment.
It should be
if (Object.keys(nextData).length > Object.keys(data).length || Object.keys(nextData).length < Object.keys(data).length)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Right now, the sortable list only updates its layout if the new data's length is larger than the previous data. On deletion, the sortable list should still update its layout.
Also, I added and documented the functionality to pass keyboardShouldPersistTaps through to the scroll view.