Return the new list order on release row #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
phuongwd approved these changes Sep 10, 2018
Open
phuongwd added a commit to phuongwd/react-native-sortable-list that referenced this pull request Dec 31, 2018
marconett added a commit to marconett/react-native-sortable-list that referenced this pull request Feb 20, 2019
| Thanks, sorry for long delay |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
onChangeOrderis called each time a row is swapped with another one, while dragging.This triggers the rerendering of the whole list, and the sorting process by the user is interrupted.
Another solution would be to wait for the end of the dragging operation, and use the
onReleaseRowcallback.In order to persist the order (for instance in a Redux store), the callback thus needs to get the new list order.