This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Don’t leave trailing whitespace #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Whatever we decide here should be applied to the Swift style guide too. |
There was a problem hiding this comment.
This is an example of what I am sick of seeing in diffs.
robrix pushed a commit to github/swift-style-guide that referenced this pull request Aug 22, 2014
Left out the trailing whitespace from github/objective-c-style-guide#58 until we decide on that.
| 👍 |
1 similar comment
| 👍 |
dannygreg pushed a commit that referenced this pull request Aug 24, 2014
Don’t leave trailing whitespace
robrix pushed a commit to github/swift-style-guide that referenced this pull request Aug 25, 2014
Brings in the no trailing whitespace section from github/objective-c-style-guide#58.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is intended to be a descriptive, rather than prescriptive change; several of us appear to have our editors configured to strip trailing whitespace, and since I’m sick of seeing whitespace changes in diffs, I suggest we standardize.
I committed (and pushed!) this straight to
masterinitially, suspiciously like an idiot might, hence why the commit here is a revert of a revert.