This repository was archived by the owner on Nov 9, 2017. It is now read-only.
instancetype in constructor instead of id for consistency #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In the declaration conventions, one of the rule says "Constructors should generally return instancetype rather than id" so perhaps the example of an initializer above should use "instancetype" instead of "id"
| Agreed! |
dannygreg pushed a commit that referenced this pull request Dec 20, 2013
instancetype in constructor instead of id for consistency
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In the declaration conventions, one of the rule says "Constructors should generally return instancetype rather than id" so perhaps the initializer example in
#pragma mark Lifecyleshould useinstancetypeinstead ofidfor consistency.