Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@jspahrsummers
Copy link
Contributor

A stab at #19.

Rendered Markdown

@dannygreg
Copy link

Good start. I think I would prefer life cycle at the very top, followed by property overrides.

@joshaber
Copy link
Contributor

That's fine with me 👍

@jspahrsummers
Copy link
Contributor Author

@dannygreg Any reason for the preference? This structure more closely matches how we've been writing our interfaces, I think.

@dannygreg
Copy link

@jspahrsummers Not really… if it lumps overridden accessors and the likes of @synchronized together. We tend to do the overrides randomly further down (below the lifecycle at least).

@jspahrsummers
Copy link
Contributor Author

I'm not sure what you're referring to with @synchronized.

I meant that this matches the order we typically declare things in header files, not how we've been doing implementations so far.

@alanjrogers
Copy link
Contributor

I used to prefer to have the lifecycle first, but in a post ARC world I think it makes sense to have property overrides first (after where @synthesize used to be).

That being said I can go either way on this, as long as they are near each other.

@dannygreg
Copy link

@jspahrsummers bah! Totally glossed over that. I still think it's weird having property accessors ahead of lifecycle.

I have near zero reasoning for that though :/.

@jspahrsummers
Copy link
Contributor Author

I've basically preferred property overrides at the top because it does put @synthesize, @dynamic, and any modified accessors all together, like @alanjrogers says.

It'd be weird to move either of the former two below Lifecycle, IMO, and I'd rather keep them together.

@jspahrsummers
Copy link
Contributor Author

Any ripostes to the above?

@joshaber
Copy link
Contributor

joshaber commented Dec 4, 2012

0.01 fudges given.

@dannygreg
Copy link

Nope, the case has been made well.

@jspahrsummers
Copy link
Contributor Author

Cool, then I'm just gonna self-merge this. :trollface:

jspahrsummers added a commit that referenced this pull request Dec 4, 2012
Outline a general structure for #pragma marks
@jspahrsummers jspahrsummers merged commit 3b8b724 into master Dec 4, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants